Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

LocalPickup: fix learn more documentation link #11241

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Oct 13, 2023

What

Fixes #11231

Why

The "Learn more" option in the Local Pickup tab links currently to the wrong document @pmcpinto reported

Testing Instructions

Please consider any edge cases this change may have, and also other areas of the product this may impact.

  1. Go to Settings > Shipping > Local Pickup
  2. Click on "Learn more" under Pickup locations
  3. Confirm that you're redirected to this page: https://woocommerce.com/document/woocommerce-blocks-local-pickup/
  • Do not include in the Testing Notes
  • Should be tested by the development team exclusively

Screenshots or screencast

Before After

WooCommerce Visibility

Required:

  • WooCommerce Core
  • Feature plugin
  • Experimental
  • N/A

Checklist

Required:

  • This PR has either a [type] label or a [skip-changelog] label.
  • This PR is assigned to a milestone.

Conditional:

  • This PR has a changelog description (if [skip-changelog] label is not present).
  • This PR adds/removes a feature flag & I've updated this doc.
  • This PR adds/removes an experimental interfaces, and I've updated this doc.
  • This PR has been accessibility tested.
  • This PR has had any necessary documentation added/updated.

Changelog

Add suggested changelog entry here.

@ralucaStan ralucaStan requested review from a team and opr and removed request for a team October 13, 2023 13:57
Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @masteradhoc thanks a lot for taking care of this! CI ran in #11260 and passed, so happy to go ahead and merge!

Just one thing, your testing instructions also include the "reproduction" instructions (checking for the broken link), we don't include those in our release testing instructions, so I'll remove them from the PR instructions too.

I'll update these to only include the "fix" instructions, like so:

Go to Settings > Shipping > Local Pickup
Click on "Learn more" under Pickup locations
Confirm that you're redirected to this page: woocommerce.com/document/woocommerce-blocks-local-pickup

@opr opr added type: bug The issue/PR concerns a confirmed bug. skip-changelog PRs that you don't want to appear in the changelog. and removed type: bug The issue/PR concerns a confirmed bug. labels Oct 16, 2023
@opr opr merged commit c861c7c into woocommerce:trunk Oct 16, 2023
30 of 40 checks passed
@masteradhoc masteradhoc deleted the patch-1 branch October 16, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-changelog PRs that you don't want to appear in the changelog. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local pickup settings tab - "learn more" links to the incorrect page
2 participants