This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Archive Templates - Compatibility Layer: fix E2E tests #11273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
gigitux
force-pushed
the
fix/compatibility-layer-e2e
branch
from
5253672 to
2c978be
Compare
kmanijak
suggested changes
Oct 17, 2023
There was a problem hiding this comment.
So with this PR the single test with multiple steps was transformed into multiple tests with single step each.
If splitting each step into separate test cases is required to fix these tests, then I think we should remove steps as they are unnecessary in such a setup. What do you think?
| @@ -51,7 +50,7 @@ const multipleOccurranceScenarios: Scenario[] = [ | |||
| { | |||
| title: 'Before Shop Loop Item Title', | |||
| dataTestId: 'woocommerce_before_shop_loop_item_title', | |||
| content: 'Hook: woocommerce_before_shop_loop_item_title', | |||
| content: ' Hook: woocommerce_before_shop_loop_item_title', | |||
There was a problem hiding this comment.
I think whitespace was added by mistake 🙌
gigitux
force-pushed
the
fix/compatibility-layer-e2e
branch
from
198a271 to
a7f81e6
Compare
gigitux
force-pushed
the
fix/compatibility-layer-e2e
branch
from
a7f81e6 to
2d9cbf4
Compare
Good point! I addressed your feedback! Thanks for the review 🙇 |
kmanijak
approved these changes
Oct 17, 2023
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Partial fixes for #11270
Why
This PR enabled the E2E tests for the compatibility layer that they were disabled with #11055.
These E2E tests started to fail after the PW update. PW documentation suggested a different approach for parameterized tests.
Applying the changes following the documentation, tests don't fail anymore.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog