This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery Pager: Remove unnecessary margin #11287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
danieldudzic
added
the
block: product gallery
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +15 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
|
Hey @danieldudzic, I don't see the |
thealexandrelara
suggested changes
Oct 20, 2023
There was a problem hiding this comment.
Thank you for working on this @danieldudzic, I just tested and can confirm that the margin was successfully removed from the block; however, I noticed that when the Pager display mode is set to "Dots" the icons the icons get cut off:
Is this happening to you as well?
I don't see the Product Gallery block in the inserter. I'm on trunk in development mode. I see the Product Image Gallery, but not the Product Gallery 🤔
Is there any error appearing in the console? I'm not sure if it's the cause, but the Product Gallery block is currently working only within the Single Product template.
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
👋 @thealexandrelara I'm struggling to replicate. It seems that a cut-off like that would be caused by incorrect icon sizing (or its container) rather than a lack of margin. Can you please share details of the browser, and specific block setup with which you were able to replicate? |
thealexandrelara
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
👋 @thealexandrelara I'm struggling to replicate.
It seems that a cut-off like that would be caused by incorrect icon sizing (or its container) rather than a lack of margin.
Can you please share details of the browser, and specific block setup with which you were able to replicate?
I was testing it again and the problem was fixed, maybe when you merged trunk into this branch, the issue was fixed because I'm not able to reproduce it anymore. Thank you for working on this, I'm approving the PR 🚀
danieldudzic
deleted the
fix/11285-product-gallery-pager-excess-margin
branch
roykho
added
the
skip-changelog
wavvves
added a commit
that referenced
this pull request
Nov 21, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
* Updated changelog and added testing instructions * Updated changelog. * Updated versions. * Updated tested up to * Updated tested up to * Uploaded testing zip * Removed #11287 from testing instructions * Added testing instructions and changelog for #11858 * Updated testing zip * Testing instructions for #11862 and #11860 * Updated testing zip * New testing zip with #11872 🍒 * Updated versions to 11.7.0-dev * Updated composer.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11285
Why
This PR removes the excess top & bottom margins from the Product Gallery Pager.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Appearance > Editor.Templates > Single Product.Convert to Blocksif you are using the Classic Templates.Product Galleryblock.Screenshots or screencast
Editor:
Frontend:
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog