This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Preparation for including Blocks as the default checkout experience in WC 8.3 #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavvves
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
senadir
reviewed
Oct 20, 2023
| $pages['cart']['content'] = '<!-- wp:woocommerce/classic-shortcode {"shortcode":"cart"} /-->'; | ||
| $pages['checkout']['content'] = '<!-- wp:woocommerce/classic-shortcode {"shortcode":"checkout"} /-->'; | ||
|
|
||
| if ( '<!-- wp:shortcode -->[woocommerce_cart]<!-- /wp:shortcode -->' === $pages['cart']['content'] ) { |
There was a problem hiding this comment.
So we're only replacing if this is the full content of the page? not a single line jump or extra filter? Why not replace '<!-- wp:shortcode -->[woocommerce_cart]<!-- /wp:shortcode -->' with '<!-- wp:woocommerce/classic-shortcode {"shortcode":"cart"} /-->'?
There was a problem hiding this comment.
You are right, but to keep previous behaviour (and possible bugs but not introduce new ones) I chose to target that specific content (most probably coming from woocommerce_create_pages default filter value).
This won't actually run on WC activation due to it being done in a child process. Currently it only applies to Tools > Create pages.
It is important to ship this on 10.4.0 so that functionality doesn't create pages with shortcodes for users with blocks 11.4.0 but WC <8.3
That means WC 8.3 PR will only be fully testable by including this.
We can revisit this later, my plan was not to rock the boat too much right now.
There was a problem hiding this comment.
I agree this makes sense now that I reviewed the PR in core.
wavvves
added
the
status: blocker
…fault-checkout-experience
senadir
approved these changes
Oct 23, 2023
wavvves
deleted the
update/preparation-for-making-blocks-the-default-checkout-experience
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change adds a check when replacing shortcodes with classic shortcode block on default cart and checkout pages.
Why
With Blocks shipping as the default checkout experience on WC 8.3, we need to make sure users on a previous version of WC still get the classic shortcode block, but not after 8.3.
This is done by checking the filter default values for shortcodes.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog