This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add missing actions to data store documentation #11986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the missing actions to the following: - data-store/cart - data-store/checkout - data-store/collections - data-store/validation
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
tarunvijwani
added
the
focus: documentation
added 4 commits
November 29, 2023 21:29
- Use store name constant instead of strings - Fix description and examples of collections document
tarunvijwani
added
the
skip-changelog
tarunvijwani
changed the title
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
nielslange
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Thanks for working on this, @tarunvijwani. To make the docs easy accessible, I suggest that we use consistent formatting throughout our docs. I left a few notes with examples.
added 3 commits
December 4, 2023 19:21
|
@nielslange Thank you so much for the suggestions! They were really helpful. I have updated the docs, please take a moment to review the PR again. |
14 tasks
nielslange
suggested changes
Dec 6, 2023
There was a problem hiding this comment.
Except for one missing parameter name, the PR looks great, @tarunvijwani.
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Niels Lange <info@nielslange.de>
|
Good catch, @nielslange. Thank you! I have applied your suggestions. 🎉 |
nielslange
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks for applying all changes. Let's ⛴️ this PR now, @tarunvijwani! 🙌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11337
Why
The actions of various data stores were not documented. With this PR, we're adding missing actions to data store documentation.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
N/A
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog