From cb9ae48a3d81c8d55a6d42967ca121a663fed2c1 Mon Sep 17 00:00:00 2001 From: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Date: Thu, 30 Nov 2023 17:29:03 +0000 Subject: [PATCH 1/2] Update feedback link --- .../js/editor-components/feedback-prompt/index.tsx | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/assets/js/editor-components/feedback-prompt/index.tsx b/assets/js/editor-components/feedback-prompt/index.tsx index 44487defd1e..939941eb874 100644 --- a/assets/js/editor-components/feedback-prompt/index.tsx +++ b/assets/js/editor-components/feedback-prompt/index.tsx @@ -71,17 +71,7 @@ export const CartCheckoutFeedbackPrompt = () => ( 'We are currently working on improving our cart and checkout blocks to provide merchants with the tools and customization options they need.', 'woo-gutenberg-products-block' ) } - url="https://github.com/woocommerce/woocommerce-gutenberg-products-block/issues/new?template=--cart-checkout-feedback.md" - /> -); - -export const LegacyFeedbackPrompt = () => ( - ); From d32c9e18ec4055cb4ccd3ef043673b9cb1cd8ba6 Mon Sep 17 00:00:00 2001 From: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Date: Fri, 1 Dec 2023 12:16:52 +0000 Subject: [PATCH 2/2] Remove default url link, and make the param required --- assets/js/editor-components/feedback-prompt/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/js/editor-components/feedback-prompt/index.tsx b/assets/js/editor-components/feedback-prompt/index.tsx index 939941eb874..c9400e25a36 100644 --- a/assets/js/editor-components/feedback-prompt/index.tsx +++ b/assets/js/editor-components/feedback-prompt/index.tsx @@ -12,7 +12,7 @@ import './style.scss'; interface FeedbackPromptProps { text: string; title?: string; - url?: string; + url: string; } /** * Component to render a Feedback prompt in the sidebar. @@ -25,7 +25,7 @@ interface FeedbackPromptProps { const FeedbackPrompt = ( { text, title = __( 'Feedback?', 'woo-gutenberg-products-block' ), - url = 'https://ideas.woocommerce.com/forums/133476-woocommerce?category_id=384565', + url, }: FeedbackPromptProps ) => { // By returning false we ensure that this component is not entered into the InspectorControls // (which is a slot fill), children array on first render, on the second render when the state