This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Adjust nesting so page wraps the main group block #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
nielslange
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. The fix works as expected. Let's ⛴️ it. 🙌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I could not completely replicate the issue in #11774 because cart/checkout blocks default to
widewidth, however, I did find that as reported, the layout controls which control page width were not respected by the content area where the page title/checkout block were placed.It seems that this was due to how blocks were nested. We had this structure:
The
Groupcontrains children, but theCart Pageblock had no alignment or width options, so this was not passed down the hierarchy.By swapping this around to:
The group correctly constrains the child blocks and widths are applied.
This is hard to explain but this should help. In this example, I've set the global wide width as follows:
Notice the width of the header vs the width of the content.
Fixes #11774
Why
Content should respect the global styles/widths.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog