Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze: Enable feature flag for evergreen campaign creation #13684

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Aug 22, 2024

Part of #13460

Description

This PR enables the feature flag blazeEvergreenCampaigns to enable creating evergreen campaigns for Blaze in production.

Steps to reproduce

  • Log in to a store eligible for Blaze.
  • Navigate to the Products tab and select an existing published product (or create a new one).
  • On the product form, select Promote with Blaze.
  • Confirm that the budget field displays a weekly budget without an end date by default.
  • Select the budget field, confirm that the budget screen displays the weekly budget and no end date.
  • Select Edit on Schedule, confirm that the Set duration screen has a switch for "Specify the duration" disabled.
  • Toggle the switch and confirm that a slider for duration appears.
  • Adjust the duration and select Apply. Confirm that the budget screen now displays the total spend for the selected duration.
  • Select Update and confirm that the budget label displays the total budget for the selected duration.
  • Tap the Budget field again, this time disable "Specify the duration" and save the change.
  • Tap Confirm Details. Confirm that the payment screen displays the weekly amount to be charged.
  • Tap Submit Campaign. The creation should succeed.
  • Check the campaign list to confirm that the latest campaign item displays the weekly budget.
  • Select the campaign and confirm that the details for duration and budget are correct.

Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-30.at.09.45.39.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: Blaze Related to the integration of the Blaze ads platform labels Aug 22, 2024
@itsmeichigo itsmeichigo added this to the 20.1 milestone Aug 22, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 22, 2024

1 Warning
⚠️ This PR is assigned to the milestone 20.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo marked this pull request as ready for review August 22, 2024 04:00
@itsmeichigo itsmeichigo marked this pull request as draft August 22, 2024 04:05
@itsmeichigo itsmeichigo modified the milestones: 20.1, 20.2 Aug 22, 2024
@itsmeichigo
Copy link
Contributor Author

Converted the PR back to draft as tracking is still missing.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 22, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13684-107c237
Version20.1
Bundle IDcom.automattic.alpha.woocommerce
Commit107c237
App Center BuildWooCommerce - Prototype Builds #10658
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review August 29, 2024 07:35
@hafizrahman hafizrahman self-assigned this Aug 29, 2024
@hafizrahman
Copy link
Contributor

  • Log in to a store eligible for Blaze.
  • Navigate to the Products tab and select an existing published product (or create a new one).
  • On the product form, select Promote with Blaze.
  • Confirm that the budget field displays a weekly budget without an end date by default.

When I tried this:

  1. In the "Set your budget" screen, the slider is showing "Daily spend" instead of "Weekly spend" like in your video
  2. The "Schedule" section has an "Edit" button that's differently designed (bold, right aligned) than the one in the "Duration" section.

I'm not sure if these are expected or not but thought to mention it first. Video below:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-29.at.21.14.30.mp4

@itsmeichigo
Copy link
Contributor Author

@hafizrahman There was an UI update done in #13748 but I forgot to update the PR description here. The UI you see is expected. Sorry for the confusion.

Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Tested the Blaze creation and duration updating flow in:

  1. Simulator iPad Pro 13 inch, iOS 17.5
  2. Simulator iPhone, iOS 17.5

👍🏼

I have some unrelated feedbacks while smoke testing this, will make separate issues for them (update: #13794, #13795)

@itsmeichigo itsmeichigo merged commit b866edc into trunk Aug 30, 2024
22 checks passed
@itsmeichigo itsmeichigo deleted the feat/13460-evergreen-campaign-support branch August 30, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Blaze Related to the integration of the Blaze ads platform type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants