Add Custom Fields to Product Model in Networking #13814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…493-new-metadata-entity-in-product
…493-new-metadata-entity-in-product
…493-new-metadata-entity-in-product
…493-new-metadata-entity-in-product
…493-new-metadata-entity-in-product
- Update `Networking.generated.swift` to include `customFields` in `Networking.Product`. - Modify `Models+Copiable.generated.swift` to add `customFields` parameter in product methods. - Adjust `AIProduct.swift` to initialize `customFields` as an empty array. - Enhance `Product.swift` to declare and handle `customFields`. - Update `Product+SwiftUIPreviewHelpers.swift` to include `customFields` in product initialization. - Modify `ProductFactory.swift` to initialize products with empty `customFields`. - Add `customFields` to mock product in `MockObjectGraph.swift`. - Adjust `Product+ReadOnlyConvertible.swift` to handle `customFields` in product storage.
pmusolino
added
type: task
|
|
…493-new-metadata-entity-in-product
Merged
4 tasks
Comment on lines
+528
to
+529
| // Filter out metadata if the key is prefixed with an underscore (internal meta keys) | ||
| let customFields = (try? container.decode([MetaData].self, forKey: .metadata).filter({ !$0.key.hasPrefix("_")})) ?? [] |
There was a problem hiding this comment.
I think we should add unit tests to ensure that customFields are mapped as expected. Probably to ProductMapperTests. What do you think?
There was a problem hiding this comment.
Good point. I implemented this test: ff9b457
- Implement test_custom_fields_are_properly_parsed in ProductMapperTests.swift to verify custom fields parsing. - Update product.json to include a new custom field with id 6000, key "just_a_custom_field", and value "10".
selanthiraiyan
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13751 part of #13493
Summary description of changes
This PR introduces custom fields to the product model, improving the flexibility of metadata handling. The changes include updates to the product struct, encoding logic, and associated mock objects to accommodate these custom fields, which will be used later. Right now, the custom fields are not used in the code, and also the Storage/Yosemite layer implementation is missing and will be handled later on.
In future PRs, AddOns and subscription that currently use metadata, should be also refactored.
Summary of changes
customFieldsproperty to theProductmodel, allowing for additional metadata to be associated with products.customFieldswhen serializing theProductobject.customFieldsare initialized and handled correctly across the system.Testing
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: