[Woo POS - payments onboarding] Enable POS for stores with incomplete payments onboarding

[jaclync]

Closes: #14147

Why

As in the project kickoff pdfdoF-5Bo-p2, I'm starting the project by adding a feature flag and enabling POS for stores with incomplete payments onboarding state behind the feature flag. I decided to add a feature flag so that it doesn't break the Installable Builds (used for Woo DM demo, if some people on the team try updating the app version) and the work is minimal.

How

• A feature flag was added paymentsOnboardingInPointOfSale, this will be removed when the project is completed
• In POSEligibilityChecker, the onboarding completed state condition is removed when the onboardingfeature flag is enabled
• A test case was added for the POSEligibilityChecker changes

There are also two small commits at the beginning where I removed unused properties while I was looking into the code. Unused code could be confusing during code search and removing it would reduce the time spent searching for its usage.

Steps to reproduce

Stores with onboarding completed

Prerequisite: the store is eligible for POS (US store, USD, WC v6.6+), and payments onboarding is completed (in Menu > Payments, no Continue setup banner is shown at the bottom)

• Launch app
• Go to Menu --> Point of Sale Mode row should appear as before
• Tap on Point of Sale Mode
• Tap Connect your reader --> connection flow should work as before

Stores with incomplete onboarding

Prerequisite: the store is eligible for POS (US store, USD, WC v6.6+), but payments onboarding is not completed (in Menu > Payments, Continue setup banner is shown at the bottom, or not using Woo Payments)

• Launch app
• Go to Menu --> Point of Sale Mode row should appear (it shouldn't appear when the feature flag is off)
• Tap on Point of Sale Mode
• Tap Connect your reader --> no-op for now, onboarding UI will be integrated in [Woo POS - payments onboarding] Show payments onboarding from existing design #14148

Testing information

I tested on iPad Pro 11in (M4) iOS 17.5 simulator with Xcode 16.

• @jaclync tests when the feature flag is off, POS remains hidden for stores without completed onboarding

Screenshots

Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2024-10-18.at.14.21.07.mp4

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14149-06f31aa
	Version	20.7
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	06f31aa
	App Center Build	WooCommerce - Prototype Builds #11183

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[staskus]

Thank you! The code changes look good! ✅

When the feature flag enabled

✅ Stores with onboarding completed - shows POS option and payment works
✅ Stores with incomplete onboarding - shows POS option and card reader button doesn't work

When the feature flag disabled (from code)

✅ Stores with onboarding completed - shows POS option and payment works
✅ Stores with incomplete onboarding - POS option is hidden