Skip to content

Commit

Permalink
Update net.wooga.plugins to version 3.x (#57)
Browse files Browse the repository at this point in the history
Description
===========

This update will bring the plugin `net.wooga.plugins` to
version `3.x`. With this change the groupname of the gradle
plugin will change during publish so I thought it might be
a good idea to change the project name as well so the groupname
won't include the `atlas` name.

The old groupname `gradle.plugin.net.wooga.gradle:atlas-appcenter`
would become `net.wooga.gradle:appcenter`.

This patch also includes all changes needed for the new
plugin metadata description.

Changes
=======

* ![UPDATE] `net.wooga.plugins` to version `3.x` range
* ![CHANGE] project name and remove `atlas` term
* ![IMPROVE] plugin publish metadata
  • Loading branch information
Larusso authored May 3, 2022
1 parent 5c8fc24 commit 0be1f7c
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 23 deletions.
5 changes: 4 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

plugins {
id "net.wooga.plugins" version "2.3.0"
id "net.wooga.plugins" version "3.2.0"
id 'net.wooga.snyk' version '0.10.0'
id "net.wooga.snyk-gradle-plugin" version "0.2.0"
id "net.wooga.cve-dependency-resolution" version "0.4.0"
Expand All @@ -28,12 +28,15 @@ pluginBundle {
website = 'https://wooga.github.io/atlas-appcenter/'
vcsUrl = 'https://github.com/wooga/atlas-appcenter'
tags = ['AppCenter']
}

gradlePlugin {
plugins {
appcenter {
id = 'net.wooga.appcenter'
displayName = 'Gradle AppCenter plugin'
description = 'This plugin provides tasks for uploading a build to AppCenter'
implementationClass = 'wooga.gradle.appcenter.AppCenterPlugin'
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ pluginManagement {
}
}

rootProject.name = 'atlas-appcenter'
rootProject.name = 'appcenter'
6 changes: 3 additions & 3 deletions src/main/groovy/wooga/gradle/appcenter/AppCenterSpec.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ import org.gradle.api.tasks.Optional

trait AppCenterSpec extends BaseSpec {

@Input
private final Property<String> apiToken = objects.property(String)

@Input
Property<String> getApiToken() {
apiToken
}
Expand All @@ -41,9 +41,9 @@ trait AppCenterSpec extends BaseSpec {
apiToken.set(value)
}

@Input
private final Property<String> owner = objects.property(String)

@Input
Property<String> getOwner() {
owner
}
Expand All @@ -56,9 +56,9 @@ trait AppCenterSpec extends BaseSpec {
owner.set(value)
}

@Input
private final Property<String> applicationIdentifier = objects.property(String)

@Input
Property<String> getApplicationIdentifier() {
applicationIdentifier
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,12 @@ import wooga.gradle.appcenter.api.AppCenterRetryStrategy

class AppCenterUploadTask extends DefaultTask implements AppCenterTaskSpec {

private final DirectoryProperty outputDir

@Internal
protected final DirectoryProperty outputDir
protected DirectoryProperty getOutputDir() {
outputDir
}

@OutputFile
final Provider<RegularFile> uploadVersionMetaData
Expand Down

This file was deleted.

0 comments on commit 0be1f7c

Please sign in to comment.