Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workingDir convention #256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add workingDir convention #256

wants to merge 4 commits into from

Conversation

Joaquimmnetto
Copy link
Contributor

@Joaquimmnetto Joaquimmnetto commented Sep 18, 2023

Description

Adds a new parameter to the pipeline configuration: workingDir. It allows you to set the current directory for all pipeline stages. On checks, this directory is relative to $checkoutDir\$checkDir. On other steps, its relative to the workspace root.

Internally it is set to a new convention field in PipelineConventions and can be passed as parameter to methods relating to different steps.

This PR also fixes bug in a inner plugin test that shown up kinda out of nowhere?

Changes

  • ADD new workingDir configuration to pipeline configuration.

@Joaquimmnetto Joaquimmnetto changed the title adds workingDir convention Adds workingDir convention Sep 18, 2023
@Joaquimmnetto Joaquimmnetto changed the title Adds workingDir convention Add workingDir convention Sep 18, 2023
@Joaquimmnetto Joaquimmnetto marked this pull request as ready for review September 18, 2023 11:55
@Joaquimmnetto Joaquimmnetto self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant