refactor: 불필요한 ObjectMapper 의존성 제거

woowa-techcamp-2024 · Aug 28, 2024 · 8d02c23 · 8d02c23
1 parent cfffb70
commit 8d02c23
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 40 deletions.
diff --git a/src/main/java/com/thirdparty/ticketing/global/config/WaitingConfig.java b/src/main/java/com/thirdparty/ticketing/global/config/WaitingConfig.java
@@ -4,7 +4,6 @@
 import org.springframework.context.annotation.Configuration;
 import org.springframework.data.redis.core.StringRedisTemplate;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.thirdparty.ticketing.domain.common.EventPublisher;
 import com.thirdparty.ticketing.domain.waitingsystem.WaitingAspect;
 import com.thirdparty.ticketing.domain.waitingsystem.WaitingSystem;
@@ -43,9 +42,8 @@ public WaitingManager waitingManager(
     }
 
     @Bean
-    public RedisWaitingRoom waitingRoom(
-            StringRedisTemplate redisTemplate, ObjectMapper objectMapper) {
-        return new RedisWaitingRoom(redisTemplate, objectMapper);
+    public RedisWaitingRoom waitingRoom(StringRedisTemplate redisTemplate) {
+        return new RedisWaitingRoom(redisTemplate);
     }
 
     @Bean

diff --git a/src/main/java/com/thirdparty/ticketing/global/waitingsystem/ObjectMapperUtils.java b/src/main/java/com/thirdparty/ticketing/global/waitingsystem/ObjectMapperUtils.java
diff --git a/...in/java/com/thirdparty/ticketing/global/waitingsystem/redis/waiting/RedisWaitingRoom.java b/...in/java/com/thirdparty/ticketing/global/waitingsystem/redis/waiting/RedisWaitingRoom.java
@@ -6,7 +6,6 @@
 import org.springframework.data.redis.core.HashOperations;
 import org.springframework.data.redis.core.StringRedisTemplate;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.thirdparty.ticketing.domain.common.ErrorCode;
 import com.thirdparty.ticketing.domain.common.TicketingException;
 import com.thirdparty.ticketing.domain.waitingsystem.waiting.WaitingRoom;
@@ -16,11 +15,9 @@ public class RedisWaitingRoom implements WaitingRoom {
     private static final String WAITING_ROOM_KEY = "waiting_room:";
 
     private final HashOperations<String, String, String> waitingRoom;
-    private final ObjectMapper objectMapper;
 
-    public RedisWaitingRoom(StringRedisTemplate redisTemplate, ObjectMapper objectMapper) {
+    public RedisWaitingRoom(StringRedisTemplate redisTemplate) {
         waitingRoom = redisTemplate.opsForHash();
-        this.objectMapper = objectMapper;
     }
 
     public boolean enter(String email, long performanceId) {

diff --git a/src/test/java/com/thirdparty/ticketing/global/waitingsystem/redis/TestRedisConfig.java b/src/test/java/com/thirdparty/ticketing/global/waitingsystem/redis/TestRedisConfig.java
@@ -41,7 +41,7 @@ public RedisWaitingManager waitingManager(
 
     @Bean
     public RedisWaitingRoom waitingRoom() {
-        return new RedisWaitingRoom(redisTemplate, objectMapper);
+        return new RedisWaitingRoom(redisTemplate);
     }
 
     @Bean

diff --git a/.../com/thirdparty/ticketing/global/waitingsystem/redis/waiting/RedisWaitingManagerTest.java b/.../com/thirdparty/ticketing/global/waitingsystem/redis/waiting/RedisWaitingManagerTest.java
@@ -18,7 +18,6 @@
 import org.springframework.data.redis.core.ZSetOperations;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.thirdparty.ticketing.support.BaseIntegrationTest;
 
 class RedisWaitingManagerTest extends BaseIntegrationTest {
@@ -27,8 +26,6 @@ class RedisWaitingManagerTest extends BaseIntegrationTest {
 
     @Autowired private StringRedisTemplate redisTemplate;
 
-    @Autowired private ObjectMapper objectMapper;
-
     @BeforeEach
     void setUp() {
         redisTemplate.getConnectionFactory().getConnection().serverCommands().flushAll();

diff --git a/...ava/com/thirdparty/ticketing/global/waitingsystem/redis/waiting/RedisWaitingRoomTest.java b/...ava/com/thirdparty/ticketing/global/waitingsystem/redis/waiting/RedisWaitingRoomTest.java
@@ -15,7 +15,6 @@
 import org.springframework.data.redis.core.HashOperations;
 import org.springframework.data.redis.core.StringRedisTemplate;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.thirdparty.ticketing.domain.common.TicketingException;
 import com.thirdparty.ticketing.support.BaseIntegrationTest;
 
@@ -25,8 +24,6 @@ class RedisWaitingRoomTest extends BaseIntegrationTest {
 
     @Autowired private StringRedisTemplate redisTemplate;
 
-    @Autowired private ObjectMapper objectMapper;
-
     private HashOperations<String, String, String> rawWaitingRoom;
 
     private String getWaitingRoomKey(long performanceId) {