Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: seat lock refactor #124

Merged
merged 3 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ public class LettuceReservationServiceProxy implements ReservationServiceProxy {
private void performSeatAction(String seatId, Runnable action) {
int retryLimit = 5;
int sleepDuration = 300;
String lockPrefix = "seat:";
String lockKey = lockPrefix + seatId;
try {
while (retryLimit > 0 && !lettuceRepository.seatLock(seatId)) {
while (retryLimit > 0 && !lettuceRepository.seatLock(lockKey)) {
retryLimit -= 1;
Thread.sleep(sleepDuration);
}
Expand All @@ -33,7 +35,7 @@ private void performSeatAction(String seatId, Runnable action) {
} catch (InterruptedException e) {
throw new TicketingException(ErrorCode.NOT_SELECTABLE_SEAT, e);
} finally {
lettuceRepository.unlock(seatId);
lettuceRepository.unlock(lockKey);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ public class RedissonReservationServiceProxy implements ReservationServiceProxy
private final ReservationTransactionService reservationTransactionService;

private void performSeatAction(String seatId, Runnable action) {
RLock lock = redissonClient.getLock(seatId);
String lockPrefix = "seat:";
RLock lock = redissonClient.getLock(lockPrefix + seatId);

int tryTime = 1;
int releaseTime = 60;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.thirdparty.ticketing.global.config;

import org.redisson.api.RedissonClient;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Primary;
Expand All @@ -22,29 +23,33 @@ public class ReservationServiceContainer {
@Bean
public ReservationService redissonReservationServiceProxy(
RedissonClient redissonClient,
ReservationTransactionService cacheReservationTransactionService) {
@Qualifier("cacheReservationTransactionService")
ReservationTransactionService cacheReservationTransactionService) {
return new RedissonReservationServiceProxy(
redissonClient, cacheReservationTransactionService);
}

@Bean
public ReservationService lettuceReservationServiceProxy(
LettuceRepository lettuceRepository,
ReservationTransactionService cacheReservationTransactionService) {
@Qualifier("cacheReservationTransactionService")
ReservationTransactionService cacheReservationTransactionService) {
return new LettuceReservationServiceProxy(
lettuceRepository, cacheReservationTransactionService);
}

@Primary
@Bean
ReservationService optimisticReservationServiceProxy(
ReservationTransactionService persistenceOptimisticReservationService) {
@Qualifier("persistenceOptimisticReservationService")
ReservationTransactionService persistenceOptimisticReservationService) {
return new OptimisticReservationServiceProxy(persistenceOptimisticReservationService);
}

@Bean
ReservationService pessimisticReservationServiceProxy(
ReservationTransactionService persistencePessimisticReservationService) {
@Qualifier("persistencePessimisticReservationService")
ReservationTransactionService persistencePessimisticReservationService) {
return new PessimisticReservationServiceProxy(persistencePessimisticReservationService);
}

Expand Down
Loading