Merge pull request #20175 from wordpress-mobile/fix/menu-visibility-o…

…n-stats Fix the visibility issue with the menu button on the stats
wordpress-mobile · Feb 12, 2024 · a8f4a27 · a8f4a27
2 parents ca3d8d8 + 43f642b
commit a8f4a27
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -2,7 +2,7 @@
 
 24.3
 -----
-
+* [*] [Jetpack-only] Fix the visibility issue with the menu button on the stats [https://github.com/wordpress-mobile/WordPress-Android/pull/20175]
 
 24.2
 -----

diff --git a/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/StatsListFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/StatsListFragment.kt
@@ -81,15 +81,12 @@ class StatsListFragment : ViewPagerFragment(R.layout.stats_list_fragment) {
         }
     }
 
-    @Suppress("DEPRECATION")
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
         statsSection = arguments?.getSerializableCompat(LIST_TYPE)
             ?: activity?.intent?.getSerializableExtraCompat(LIST_TYPE)
                     ?: StatsSection.INSIGHTS
-
-        setHasOptionsMenu(statsSection == StatsSection.INSIGHTS)
     }
 
     override fun onSaveInstanceState(outState: Bundle) {
@@ -210,6 +207,12 @@ class StatsListFragment : ViewPagerFragment(R.layout.stats_list_fragment) {
         }
     }
 
+    override fun onResume() {
+        super.onResume()
+        @Suppress("DEPRECATION")
+        setHasOptionsMenu(statsSection == StatsSection.INSIGHTS)
+    }
+
     override fun onDestroyView() {
         super.onDestroyView()
         binding = null