From b73b46dc4f5c5623a1d709371200f56d7b9b3fc1 Mon Sep 17 00:00:00 2001 From: Ajesh R Pai Date: Fri, 22 Mar 2024 15:02:04 +0530 Subject: [PATCH] =?UTF-8?q?=E2=86=91=20Updates:=20the=20naming=20of=20the?= =?UTF-8?q?=20function?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../android/ui/mysite/cards/DashboardCardsViewModelSlice.kt | 4 ++-- .../bloggingprompts/BloggingPromptCardViewModelSlice.kt | 6 +++--- .../android/ui/mysite/DashboardCardsViewModelSliceTest.kt | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/DashboardCardsViewModelSlice.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/DashboardCardsViewModelSlice.kt index 8b83cc3cd8da..f86b8de9af89 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/DashboardCardsViewModelSlice.kt +++ b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/DashboardCardsViewModelSlice.kt @@ -190,7 +190,7 @@ class DashboardCardsViewModelSlice @Inject constructor( jpMigrationSuccessCardViewModelSlice.buildCard() jetpackInstallFullPluginCardViewModelSlice.buildCard(site) blazeCardViewModelSlice.buildCard(site) - bloggingPromptCardViewModelSlice.buildCard(site) + bloggingPromptCardViewModelSlice.fetchBloggingPrompt(site) bloganuaryNudgeCardViewModelSlice.buildCard() personalizeCardViewModelSlice.buildCard() quickLinksItemViewModelSlice.buildCard(site) @@ -226,7 +226,7 @@ class DashboardCardsViewModelSlice @Inject constructor( fun refreshBloggingPrompt() { selectedSiteRepository.getSelectedSite()?.let { - bloggingPromptCardViewModelSlice.buildCard(it) + bloggingPromptCardViewModelSlice.fetchBloggingPrompt(it) } } diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardViewModelSlice.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardViewModelSlice.kt index 9512f75b7ff2..da6e61de3fa1 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardViewModelSlice.kt +++ b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardViewModelSlice.kt @@ -62,7 +62,7 @@ class BloggingPromptCardViewModelSlice @Inject constructor( private lateinit var scope: CoroutineScope - fun buildCard( + fun fetchBloggingPrompt( siteModel: SiteModel ) { scope.launch(bgDispatcher) { @@ -107,7 +107,7 @@ class BloggingPromptCardViewModelSlice @Inject constructor( this.scope = scope } - private fun buildCard(bloggingPromptUpdate: BloggingPromptModel): BloggingPromptCardWithData? { + private fun fetchBloggingPrompt(bloggingPromptUpdate: BloggingPromptModel): BloggingPromptCardWithData? { return bloggingPromptCardBuilder.build(getBuilderParams(bloggingPromptUpdate)) } @@ -191,7 +191,7 @@ class BloggingPromptCardViewModelSlice @Inject constructor( private fun postState(bloggingPrompt: BloggingPromptModel?) { _isRefreshing.postValue(false) bloggingPrompt?.let { - buildCard(bloggingPrompt)?.let { card -> + fetchBloggingPrompt(bloggingPrompt)?.let { card -> _uiModel.postValue(card) } } ?: _uiModel.postValue(null) diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/DashboardCardsViewModelSliceTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/DashboardCardsViewModelSliceTest.kt index aa20a6ccf937..5ee11706eb38 100644 --- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/DashboardCardsViewModelSliceTest.kt +++ b/WordPress/src/test/java/org/wordpress/android/ui/mysite/DashboardCardsViewModelSliceTest.kt @@ -119,7 +119,7 @@ class DashboardCardsViewModelSliceTest: BaseUnitTest() { verify(jpMigrationSuccessCardViewModelSlice, atMost(1)).buildCard() verify(jetpackInstallFullPluginCardViewModelSlice, atMost(1)).buildCard(mockSite) verify(blazeCardViewModelSlice, atMost(1)).buildCard(mockSite) - verify(bloggingPromptCardViewModelSlice, atMost(1)).buildCard(mockSite) + verify(bloggingPromptCardViewModelSlice, atMost(1)).fetchBloggingPrompt(mockSite) verify(bloganuaryNudgeCardViewModelSlice, atMost(1)).buildCard() verify(personalizeCardViewModelSlice, atMost(1)).buildCard() verify(quickLinksItemViewModelSlice, atMost(1)).buildCard(mockSite) @@ -168,7 +168,7 @@ class DashboardCardsViewModelSliceTest: BaseUnitTest() { dashboardCardsViewModelSlice.refreshBloggingPrompt() - verify(bloggingPromptCardViewModelSlice).buildCard(mockSite) + verify(bloggingPromptCardViewModelSlice).fetchBloggingPrompt(mockSite) } @Test