- Removes: Redundant JetpackInstallFullPluginCardBuilderParams

wordpress-mobile · Mar 25, 2024 · cbee896 · cbee896
1 parent 8120e49
commit cbee896
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 24 deletions.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItemBuilderParams.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItemBuilderParams.kt
@@ -185,12 +185,6 @@ sealed class MySiteCardAndItemBuilderParams {
         val onActionClick: () -> Unit
     )
 
-    data class JetpackInstallFullPluginCardBuilderParams(
-        val site: SiteModel,
-        val onLearnMoreClick: () -> Unit,
-        val onHideMenuItemClick: () -> Unit,
-    )
-
     data class PersonalizeCardBuilderParams(
         val onClick: () -> Unit
     )

diff --git a/...android/ui/mysite/cards/jpfullplugininstall/JetpackInstallFullPluginCardViewModelSlice.kt b/...android/ui/mysite/cards/jpfullplugininstall/JetpackInstallFullPluginCardViewModelSlice.kt
@@ -5,7 +5,6 @@ import androidx.lifecycle.distinctUntilChanged
 import org.wordpress.android.analytics.AnalyticsTracker
 import org.wordpress.android.fluxc.model.SiteModel
 import org.wordpress.android.ui.mysite.MySiteCardAndItem.Card.JetpackInstallFullPluginCard
-import org.wordpress.android.ui.mysite.MySiteCardAndItemBuilderParams.JetpackInstallFullPluginCardBuilderParams
 import org.wordpress.android.ui.mysite.SelectedSiteRepository
 import org.wordpress.android.ui.prefs.AppPrefsWrapper
 import org.wordpress.android.ui.utils.ListItemInteraction
@@ -41,26 +40,16 @@ class JetpackInstallFullPluginCardViewModelSlice @Inject constructor(
         _onOpenJetpackInstallFullPluginOnboarding.postValue(Event(Unit))
     }
 
-    fun buildCard(site: SiteModel) {
-        build(
-            JetpackInstallFullPluginCardBuilderParams(
-                site = site,
-                onLearnMoreClick = this::onJetpackInstallFullPluginLearnMoreClick,
-                onHideMenuItemClick = this::onJetpackInstallFullPluginHideMenuItemClick
-            )
-        )
-    }
-
-    fun build(
-        params: JetpackInstallFullPluginCardBuilderParams
+    fun buildCard(
+        site: SiteModel
     ) {
-        if (shouldShowCard(params.site)) {
+        if (shouldShowCard(site)) {
             _uiModel.postValue(
                 JetpackInstallFullPluginCard(
-                    siteName = params.site.name,
-                    pluginNames = params.site.activeIndividualJetpackPluginNames().orEmpty(),
-                    onLearnMoreClick = ListItemInteraction.create(params.onLearnMoreClick),
-                    onHideMenuItemClick = ListItemInteraction.create(params.onHideMenuItemClick),
+                    siteName = site.name,
+                    pluginNames = site.activeIndividualJetpackPluginNames().orEmpty(),
+                    onLearnMoreClick = ListItemInteraction.create(this::onJetpackInstallFullPluginLearnMoreClick),
+                    onHideMenuItemClick = ListItemInteraction.create(this::onJetpackInstallFullPluginHideMenuItemClick),
                 )
             )
         } else _uiModel.postValue(null)