Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Rename the label to edit/manage Tags and Sites #20457

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

daniloercoli
Copy link
Contributor

Fixes #20454
This PR changes the Edit label to Manage in the bottom sheet that allows you to select Tags and Sites.

Ref: p1710330177642939-slack-C05N140C8H5


To Test:

  • Open the Reader
  • Go to Subscriptions and tap on the Tag pill
  • The bottom sheet that shows Your Tags, shows the Manage label on top-right.
  • Tapping on Manage open the Manage Tags and Sites screen
  • Repeat the steps above for Blogs

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20457-74d017f
Commit74d017f
Direct Downloadjetpack-prototype-build-pr20457-74d017f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20457-74d017f
Commit74d017f
Direct Downloadwordpress-prototype-build-pr20457-74d017f.apk
Note: Google Login is not supported on these builds.

@RenanLukas RenanLukas self-assigned this Mar 13, 2024
Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @daniloercoli.
It's working as expected and code LGTM :shipit:

Perhaps later it also makes sense to change the manage screen title to "Manage" instead of "Manage Tags & Blogs" in a separate issue.

image

@daniloercoli daniloercoli merged commit b3c7fcf into trunk Mar 14, 2024
20 of 25 checks passed
@daniloercoli daniloercoli deleted the issue/20454-Reader-Rename-Edit-button branch March 14, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reader] Rename the Edit button label to Manage
3 participants