Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Design System color definitions #20464

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

aditi-bhatia
Copy link
Contributor

@aditi-bhatia aditi-bhatia commented Mar 13, 2024

Part of issue #19802
Fixes #20345
Figma with Android definitions: LyzJJa6ANKToUswWmRrZee-fi-301_26

This PR updates the Design System color definitions to the new ones provided by Design (see Figma above).

Before After
Light Mode Screenshot 2024-03-14 at 11 52 20 PM Screenshot 2024-03-14 at 11 53 11 PM
Dark Mode Screenshot 2024-03-14 at 11 52 07 PM Screenshot 2024-03-14 at 11 53 21 PM

To Test:

  1. Navigate to the Me tab. If you're on a debug build, you should see the Design System row.
  2. Click Foundation -> Colors.
  3. Ensure the colors match the ones in the Figma with the corresponding theme of your app.
  4. Toggle between light mode/dark mode under App Settings.
  5. Navigate back to the Colors screen and the colors should match the ones in the Figma with the corresponding theme.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • None
  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 13, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.5. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20464-ae1cccd
Commitae1cccd
Direct Downloadjetpack-prototype-build-pr20464-ae1cccd.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20464-ae1cccd
Commitae1cccd
Direct Downloadwordpress-prototype-build-pr20464-ae1cccd.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 40.44%. Comparing base (2f25490) to head (ae1cccd).
Report is 37 commits behind head on trunk.

Files Patch % Lines
...press/android/designsystem/DesignSystemAppColor.kt 0.00% 10 Missing ⚠️
...ordpress/android/designsystem/DesignSystemTheme.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20464      +/-   ##
==========================================
- Coverage   40.44%   40.44%   -0.01%     
==========================================
  Files        1462     1462              
  Lines       67241    67242       +1     
  Branches    11176    11176              
==========================================
  Hits        27193    27193              
- Misses      37573    37574       +1     
  Partials     2475     2475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

Please add screenshots of before, and after change.

@aditi-bhatia
Copy link
Contributor Author

Thanks for the review @ravishanker! Added the screenshots to the description above 👍

@aditi-bhatia aditi-bhatia merged commit 3e2363d into trunk Mar 15, 2024
24 of 38 checks passed
@aditi-bhatia aditi-bhatia deleted the origin/issue/20345-update-DS-colors branch March 15, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design System]: Update DS color definitions to Android values provided by Design
4 participants