-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Design System color definitions #20464
Conversation
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20464 +/- ##
==========================================
- Coverage 40.44% 40.44% -0.01%
==========================================
Files 1462 1462
Lines 67241 67242 +1
Branches 11176 11176
==========================================
Hits 27193 27193
- Misses 37573 37574 +1
Partials 2475 2475 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
Please add screenshots of before, and after change.
Thanks for the review @ravishanker! Added the screenshots to the description above 👍 |
Part of issue #19802
Fixes #20345
Figma with Android definitions: LyzJJa6ANKToUswWmRrZee-fi-301_26
This PR updates the Design System color definitions to the new ones provided by Design (see Figma above).
To Test:
Foundation
->Colors
.App Settings
.Colors
screen and the colors should match the ones in the Figma with the corresponding theme.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):