Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reader] Fix IllegalStateException in ReaderPostListFragment #20507

Merged
merged 3 commits into from
Mar 22, 2024
Merged

[Reader] Fix IllegalStateException in ReaderPostListFragment #20507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78d3c14
Make sure the Fragment is attached to the activity onResume
daniloercoli Mar 19, 2024
ae0e624
Check the fragment is still attached to the activity when the updateC…
daniloercoli Mar 21, 2024
88e9cab
Move the code that checks if the Fragment is still attached closer to…
daniloercoli Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import androidx.appcompat.widget.SearchView;
import androidx.core.content.ContextCompat;
import androidx.core.text.HtmlCompat;
import androidx.fragment.app.FragmentActivity;
import androidx.fragment.app.FragmentManager;
import androidx.lifecycle.ViewModelProvider;
import androidx.recyclerview.widget.RecyclerView;
Expand Down Expand Up @@ -2321,9 +2322,19 @@ private void updateCurrentTagIfTime() {
@Override
public void run() {
if (ReaderTagTable.shouldAutoUpdateTag(getCurrentTag()) && isAdded()) {
requireActivity().runOnUiThread(() -> updateCurrentTag());
// Check the fragment is attached right after `shouldAutoUpdateTag`
FragmentActivity activity = getActivity();
if (activity == null) {
return;
}
activity.runOnUiThread(() -> updateCurrentTag());
} else {
requireActivity().runOnUiThread(() -> {
// Check the fragment is attached to the activity when this Thread starts.
FragmentActivity activity = getActivity();
if (activity == null) {
return;
}
activity.runOnUiThread(() -> {
if (isBookmarksList() && isPostAdapterEmpty() && isAdded()) {
setEmptyTitleAndDescriptionForBookmarksList();
mActionableEmptyView.image.setImageResource(
Expand Down
Loading