Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open traffic tab from today's stats card #20526

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Mar 25, 2024

Fixes #20487

This updates Today's Stats card to have it open "By day" granularity.


To Test:

Test this with both the stats_traffic_tab enabled and disabled cases:

  1. Open "My Site → Stats"
  2. Change granularity to something different from "Day".
  3. Tap on the "Today's Stats" card from My Site.
  4. Verify that it opens the Day granularity in Stats.

Regression Notes

  1. Potential unintended areas of impact

    • Opening Stats from other entry points.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Tested manually.
  3. What automated tests I added (or what prevented me from doing so)

    • Updated current tests.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@irfano irfano added this to the 24.6 milestone Mar 25, 2024
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20526-7cbb4fb
Commit7cbb4fb
Direct Downloadjetpack-prototype-build-pr20526-7cbb4fb.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20526-7cbb4fb
Commit7cbb4fb
Direct Downloadwordpress-prototype-build-pr20526-7cbb4fb.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 40.24%. Comparing base (93d9440) to head (7cbb4fb).

Files Patch % Lines
...rdpress/android/ui/stats/refresh/StatsViewModel.kt 50.00% 1 Missing and 2 partials ⚠️
...d/ui/stats/refresh/utils/SelectedSectionManager.kt 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20526   +/-   ##
=======================================
  Coverage   40.24%   40.24%           
=======================================
  Files        1462     1462           
  Lines       67592    67592           
  Branches    11200    11200           
=======================================
+ Hits        27201    27204    +3     
+ Misses      37931    37927    -4     
- Partials     2460     2461    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker merged commit 28ac162 into trunk Mar 26, 2024
21 of 23 checks passed
@ravishanker ravishanker deleted the issue/20487-open-traffic-from-todays-stats-card branch March 26, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Today's Stats card should open the day granularity on stats
3 participants