Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Use a shared Buildkite pipeline vars file #21026

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Jul 1, 2024

References

This PR requires https://github.com/Automattic/buildkite-ci/pull/459 to be deployed first.
The "pipeline upload" CI step will fail on this PR until then.

See also: https://wp.me/paaHJt-5Rr

What it does

This PR introduces the pipeline variables CI_TOOLKIT and TEST_COLLECTOR, both defined in ./buildkite/shared-pipeline-vars, and replaces them across all pipelines.

How to test

@iangmaia iangmaia added this to the 25.3 milestone Jul 1, 2024
@iangmaia iangmaia self-assigned this Jul 1, 2024
@iangmaia iangmaia marked this pull request as ready for review July 1, 2024 18:10
@iangmaia iangmaia requested a review from a team July 1, 2024 18:10
# to set up some variables that will be interpolated in the `.yml` pipeline before uploading it.

export CI_TOOLKIT="automattic/a8c-ci-toolkit#3.4.2"
export TEST_COLLECTOR="test-collector#v1.10.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope the jump fro 1.8.0 to 1.10.1 won't break anything! (It shouldn't if they respect semver…)

Copy link

sonarcloud bot commented Jul 1, 2024

@AliSoftware
Copy link
Contributor

Restarted the build on Buildkite now that https://github.com/Automattic/buildkite-ci/pull/459 is merged, and pipeline upload passed 👍

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21026-47ebbae
Commit47ebbae
Direct Downloadjetpack-prototype-build-pr21026-47ebbae.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21026-47ebbae
Commit47ebbae
Direct Downloadwordpress-prototype-build-pr21026-47ebbae.apk
Note: Google Login is not supported on these builds.

@iangmaia iangmaia merged commit 58d5813 into trunk Jul 2, 2024
20 checks passed
@iangmaia iangmaia deleted the iangmaia/shared-buildkite-pipeline-vars branch July 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants