[Tooling] Use a trusted CI agent for pipelines that require push access #21028
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,18 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json | ||
| --- | ||
|
|
||
|
|
||
| steps: | ||
| - label: "Code Freeze" | ||
| plugins: [$CI_TOOLKIT] | ||
| command: | | ||
| echo '--- :robot_face: Use bot for git operations' | ||
| source use-bot-for-git | ||
|
|
||
| echo '--- :ruby: Setup Ruby Tools' | ||
| install_gems | ||
|
|
||
| echo '--- :snowflake: Start Code Freeze' | ||
| bundle exec fastlane code_freeze skip_confirm:true | ||
| agents: | ||
| queue: "tumblr-metal" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,21 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json | ||
| --- | ||
|
|
||
|
|
||
| steps: | ||
| - label: "Complete Code Freeze" | ||
| plugins: [$CI_TOOLKIT] | ||
| command: | | ||
| echo '--- :robot_face: Use bot for git operations' | ||
| source use-bot-for-git | ||
|
|
||
| echo '--- :git: Checkout Release Branch' | ||
| .buildkite/commands/checkout-release-branch.sh | ||
|
|
||
| echo '--- :ruby: Setup Ruby Tools' | ||
| install_gems | ||
|
|
||
| echo '--- :snowflake: Complete Code Freeze' | ||
| bundle exec fastlane complete_code_freeze skip_confirm:true | ||
| agents: | ||
| queue: "tumblr-metal" | ||
|
There was a problem hiding this comment. Maybe this has been discussed elsewhere, in which case apologies for the redundancy, but it would be nice for this to eventually be an agent that doesn't have Tumblr in the name 😄 There was a problem hiding this comment. Yep, whenever I type |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,23 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json | ||
| --- | ||
|
|
||
|
|
||
| steps: | ||
| - label: "Finalize release" | ||
| plugins: [$CI_TOOLKIT] | ||
| command: | | ||
| echo '--- :robot_face: Use bot for git operations' | ||
| source use-bot-for-git | ||
|
|
||
| echo '--- :git: Checkout Release Branch' | ||
| .buildkite/commands/checkout-release-branch.sh | ||
|
|
||
| echo '--- :ruby: Setup Ruby Tools' | ||
| install_gems | ||
|
|
||
| cp gradle.properties-example gradle.properties | ||
|
|
||
| echo '--- :shipit: Finalize Release' | ||
| bundle exec fastlane finalize_release skip_confirm:true | ||
| agents: | ||
| queue: "tumblr-metal" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,20 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json | ||
| --- | ||
|
|
||
|
|
||
| steps: | ||
| - label: "New Beta Release" | ||
| plugins: [$CI_TOOLKIT] | ||
| command: | | ||
| echo '--- :robot_face: Use bot for git operations' | ||
| source use-bot-for-git | ||
|
|
||
| echo '--- :ruby: Setup Ruby Tools' | ||
| install_gems | ||
|
|
||
| cp gradle.properties-example gradle.properties | ||
|
|
||
| echo '--- :shipit: New Beta Release' | ||
| bundle exec fastlane new_beta_release skip_confirm:true | ||
| agents: | ||
| queue: "tumblr-metal" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,21 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json | ||
| --- | ||
|
|
||
|
|
||
| steps: | ||
| - label: "Update release notes" | ||
| plugins: [$CI_TOOLKIT] | ||
| command: | | ||
| echo '--- :robot_face: Use bot for git operations' | ||
| source use-bot-for-git | ||
|
|
||
| echo '--- :git: Checkout Editorial Branch' | ||
| .buildkite/commands/checkout-editorial-branch.sh | ||
|
|
||
| echo '--- :ruby: Setup Ruby Tools' | ||
| install_gems | ||
|
|
||
| echo '--- :memo: Update Release Notes' | ||
| bundle exec fastlane update_appstore_strings version:${RELEASE_VERSION} | ||
| agents: | ||
| queue: "tumblr-metal" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tidy up.
Have you considered:
I never tried it but I assume the Buildkite parser would be smart enough to allow a scalar value here and convert it to a sequence internally.
However, maybe we're better off leaving the
[ ]so the diff when adding a new plugin will be smaller 🤷♂️There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think that Buildkite would allow a single value in an attribute expecting an array (and would wrap it in an array automatically for us) and thus allow such a syntax… personally I prefer to be explicit in it being an array and thus keep the
[…]syntax.