Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Jetpack Migration to Material3 #21318

Draft
wants to merge 17 commits into
base: trunk
Choose a base branch
from

Conversation

nbradbury
Copy link
Contributor

This PR converts the Jetpack migration flow to Material3. This is not an easy flow to test so I recommending relying on previewing the various "step" screens under org.wordpress.android.ui.main.jetpack.migration.compose.state as shown below.

Note: This should not be merged until both #21315 & #21316 have been merged.

DeleteStep
delete

DoneStep
done

ErrorStep
error

NotificationsStep
notifications

WelcomeStep
welcome

@nbradbury nbradbury added Tech Debt Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging UI labels Oct 18, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Oct 18, 2024

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21318-0c855f7
Commit0c855f7
Direct Downloadwordpress-prototype-build-pr21318-0c855f7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21318-0c855f7
Commit0c855f7
Direct Downloadjetpack-prototype-build-pr21318-0c855f7.apk
Note: Google Login is not supported on these builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Tech Debt UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants