-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3077 from wordpress-mobile/fix/metadata-no-id-npe
FromJson returns null when json doesn't contain required fields
- Loading branch information
Showing
2 changed files
with
86 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
plugins/woocommerce/src/test/java/org/wordpress/android/fluxc/model/WCMetaDataTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
package org.wordpress.android.fluxc.model | ||
|
||
import com.google.gson.JsonObject | ||
import org.assertj.core.api.Assertions.assertThat | ||
import org.junit.Test | ||
import org.wordpress.android.fluxc.model.WCMetaData.Companion.ID | ||
import org.wordpress.android.fluxc.model.WCMetaData.Companion.KEY | ||
import org.wordpress.android.fluxc.model.WCMetaData.Companion.VALUE | ||
|
||
class WCMetaDataTest { | ||
@Test | ||
fun `when all required fields are present, should return a WCMetaData`() { | ||
val id = 1234L | ||
val key = "this_is_the_key" | ||
val value = "random value" | ||
|
||
val metadataJson = JsonObject().apply { | ||
addProperty(ID, id) | ||
addProperty(KEY, key) | ||
addProperty(VALUE, value) | ||
} | ||
|
||
val metadata = WCMetaData.fromJson(metadataJson) | ||
|
||
assertThat(metadata).isNotNull | ||
assertThat(metadata!!.id).isEqualTo(id) | ||
assertThat(metadata.key).isEqualTo(key) | ||
assertThat(metadata.value.stringValue).isEqualTo(value) | ||
} | ||
|
||
@Test | ||
fun `when ID is missing, should return null`() { | ||
val key = "this_is_the_key" | ||
val value = "random value" | ||
|
||
val metadataJson = JsonObject().apply { | ||
addProperty(KEY, key) | ||
addProperty(VALUE, value) | ||
} | ||
|
||
val metadata = WCMetaData.fromJson(metadataJson) | ||
|
||
assertThat(metadata).isNull() | ||
} | ||
|
||
@Test | ||
fun `when Key is missing, should return null`() { | ||
val id = 1234L | ||
val value = "random value" | ||
|
||
val metadataJson = JsonObject().apply { | ||
addProperty(ID, id) | ||
addProperty(VALUE, value) | ||
} | ||
|
||
val metadata = WCMetaData.fromJson(metadataJson) | ||
|
||
assertThat(metadata).isNull() | ||
} | ||
|
||
@Test | ||
fun `when Value is missing, should return null`() { | ||
val id = 1234L | ||
val key = "this_is_the_key" | ||
|
||
val metadataJson = JsonObject().apply { | ||
addProperty(ID, id) | ||
addProperty(KEY, key) | ||
} | ||
|
||
val metadata = WCMetaData.fromJson(metadataJson) | ||
|
||
assertThat(metadata).isNull() | ||
} | ||
} |