-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JPAandroid] Add endpoints and DB layer for Blaze Campaigns #2763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, indicates that an accept header needs to be added to the request.This is needed for DSP blaze calls.
…e to model to entity
…l. Include the needed json migration file.
…tructor so the Accept header will be added to the request, as the endpoint requires it.
…ampaign data from the database. Transactions are used to insert and delete, so the pagination data stays in sync with the campaign data.
AjeshRPai
reviewed
Jul 4, 2023
...c/main/java/org/wordpress/android/fluxc/network/rest/wpcom/blaze/BlazeCampaignsRestClient.kt
Show resolved
Hide resolved
…, and store budgetCents as a long
…them to the request is simplified.
16 tasks
@AjeshRPai - This PR has been replaced with #2768 . This branch will be deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
budgetCents
is stored as a Long in the DB, it's up to the UI layer to format as USD.BaseWPComRestClient.java
to accept aAcceptHeaderStrategy
. This strategy encapsulates Accept Headers that need to be applied to the request. Other strategies can be easily added and injected into child rest client classes.This PR will use JPAndroid PR as a testing companion. However, if needed, a separate JP Android PR will be created with a hash only.