Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JPAandroid] Add endpoints and DB layer for Blaze Campaigns #2763

Closed
wants to merge 24 commits into from

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Jul 1, 2023

This PR adds support for:

  • Calling the blaze search campaign endpoint
  • DB layer for storing blaze campaign data and associated paging information
  • Clicks and impressions - Defaulting null to "0"
  • budgetCents is stored as a Long in the DB, it's up to the UI layer to format as USD.
  • URL is set as nullable, even though it is required for JP blaze. (Tumblr doesn't require an image, so setting it as nullable will help prevent possible crashes in the future
  • A new constructor was added to BaseWPComRestClient.java to accept a AcceptHeaderStrategy. This strategy encapsulates Accept Headers that need to be applied to the request. Other strategies can be easily added and injected into child rest client classes.

This PR will use JPAndroid PR as a testing companion. However, if needed, a separate JP Android PR will be created with a hash only.

zwarm added 10 commits July 1, 2023 13:46
…, indicates that an accept header needs to be added to the request.This is needed for DSP blaze calls.
…tructor so the Accept header will be added to the request, as the endpoint requires it.
…ampaign data from the database. Transactions are used to insert and delete, so the pagination data stays in sync with the campaign data.
@zwarm zwarm added the Blaze label Jul 1, 2023
@zwarm zwarm requested a review from AjeshRPai July 1, 2023 18:07
@zwarm zwarm self-assigned this Jul 1, 2023
@zwarm zwarm marked this pull request as ready for review July 9, 2023 02:22
@zwarm
Copy link
Contributor Author

zwarm commented Jul 9, 2023

@AjeshRPai - This PR has been replaced with #2768 . This branch will be deleted.

@zwarm zwarm closed this Jul 9, 2023
@zwarm zwarm deleted the issue/18523-jpandroid-fetch-blaze-campaigns branch July 9, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants