Update Compose in the example app to use the Android Dependency Catalog #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParaskP7
reviewed
Aug 26, 2024
There was a problem hiding this comment.
👋 @hichamboushaba !
I have reviewed this PR and it LGTM, thank YOU! 🌟
I just made a suggestion (💡) on Compose Compiler here as I think it is better we declare and use that version too, no matter how temporarily. Let me know your thoughts.
FYI: Afterwards we can proceed with creating a new tag for ADC, use that on the FluxC side and merge this.
|
@ParaskP7 the PR was updated with the latest ADC version and with a change to use ADC for the compose compiler version too, ready for another round. |
ParaskP7
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Awesome, this LGTM, feel free to merge when CI completes, thanks for your efforts @hichamboushaba ! 🚀 🙇 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Android Dependency Catalog, and then Compose to use it.
Testing
Successful compilation is enough, on my side I already tested the changes using the steps of this PR