Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Link header values into different items #3104

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Split Link header values into different items #3104

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b80a18
Split Link header values into different items
JorgeMucientes Sep 27, 2024
788b569
Use directly Link header value
JorgeMucientes Sep 30, 2024
79ea8e5
Revert accidentally committed change
JorgeMucientes Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fluxc/src/main/java/org/wordpress/android/fluxc/network/discovery/WPAPIHeadRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ class WPAPIHeadRequest(
override fun parseNetworkResponse(response: NetworkResponse): Response<List<Header>?>? {
val headers = response.allHeaders
?.filter { it.name.equals(LINK_HEADER_NAME, ignoreCase = true) }
?.flatMap {
it.value.split(",")
.map { value -> Header(LINK_HEADER_NAME, value.trimStart()) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor np, we can avoid the instantiation of new Header objects here if we directly return List<String> instead of List<Header> in the request, as we don't need the header itself, we just its value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! Applied!

}
?.ifEmpty { null }

return if (headers != null) {
Expand Down
Loading