[Woo] Extract subscriptions outside of WCProductModel table #3106
Conversation
hichamboushaba
force-pushed
the
woo/subscriptions-off-product
branch
from
171b7c1
to
f30d1b6
Compare
| data class MetadataChanges( | ||
| val insertedMetadata: List<WCMetaData> = emptyList(), | ||
| val updatedMetadata: List<WCMetaData> = emptyList(), | ||
| val deletedMetadataIds: List<Long> = emptyList(), | ||
| ) { |
There was a problem hiding this comment.
I extracted this bit to a separate class, this class can now be used in other places when needed (now it's used in WCProductStore, but can be used for orders as well), while the UpdateMetadataRequest will still be used for the MetadataStore operations.
My goal of extracting this is to not have to deal with unneeded information for the other usages (I mean parentItemId and parentItemType).
hichamboushaba
force-pushed
the
woo/subscriptions-off-product
branch
from
ce95ccf
to
5dd2a27
Compare
| operator fun invoke(value: String?): WCMetaDataValue { | ||
| if (value == null) return StringValue(null) | ||
|
|
||
| return runCatching { JsonParser().parse(value) } | ||
| .getOrElse { JsonPrimitive(value) } | ||
| .let { fromJsonElement(it) } | ||
| } | ||
| operator fun invoke(value: Number): WCMetaDataValue = NumberValue(value) | ||
| operator fun invoke(value: Boolean): WCMetaDataValue = BooleanValue(value) |
There was a problem hiding this comment.
Just a nicer way to instantiate the values instead of the fromRawString version.
|
|
||
| 204 -> migrateAddOn(ADDON_WOOCOMMERCE, version) { | ||
| // Drop the column METADATA from WCProductModel | ||
| // Since SQLite version varies accross devices, we can't rely on the support of DROP COLUMN, |
There was a problem hiding this comment.
Well spotted as most Android versions won't support alter table -> drop column operation. It seems this was added in SQLite 3.35.0 and it was in Android API 34 when SQLite was updated to a version > 3.35.0
Super minor np, typo in across word
This PR has two main changes:
METADATAcolumn from theWCProductModeltable.Testing
Testing steps are provided in woocommerce/woocommerce-android#12766 and woocommerce/woocommerce-android#12767