Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GHHELPER_REPO to GITHUB_REPO #20072

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Feb 7, 2023

GHHELPER_REPO used to be a meaningful name in release-toolkit, but as of version 6.0.0, that is no longer the case.

GITHUB_REPO is a much clearer and appropriate name for what the constant represents.

Testing

This is a mechanical find and replace (find . -name '*.rb' -o -name 'Fastfile' -print0 | xargs -0 sed -i "" "s/GHHELPER_REPO/GITHUB_REPO/g"). Checking the diff is all we need.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

`GHHELPER_REPO` used to be a meaningful name in release-toolkit, but as
of version 6.0.0, that [is no longer the case](wordpress-mobile/release-toolkit#420).

`GITHUB_REPO` is a much clearer and appropriate name for what the
constant represents.
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Feb 7, 2023
@mokagio mokagio added this to the 21.8 milestone Feb 7, 2023
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20072-d6c2e92 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20072-d6c2e92 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio merged commit 83bfa59 into trunk Feb 7, 2023
@mokagio mokagio deleted the mokagio/rename-ghhelper_repo branch February 7, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants