Fix release notes for the Plans in Site Creation project

[irfano]

Plans in Site Creation project will be publicly available in version 23.6. This PR removes the incorrect [internal] tag and extra [***] from the release note.

[peril-wordpress-mobile]

	Warnings
⚠️	This PR contains changes to RELEASE_NOTES.txt. Note that these changes won't affect the final version of the release notes as this version is in code freeze. Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 dangerJS

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21912-ca68759
	Version	23.6
	Bundle ID	org.wordpress.alpha
	Commit	ca68759
	App Center Build	WPiOS - One-Offs #7593

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21912-ca68759
	Version	23.6
	Bundle ID	com.jetpack.alpha
	Commit	ca68759
	App Center Build	jetpack-installable-builds #6616

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[tiagomar]

Thanks for the fix! 🙇

[irfano]

Hey, @mokagio! We've merged this PR that corrects the release notes into the release/23.6 branch.

[mokagio]

Hi @irfano 👋 Thanks for the ping. Out of curiosity, was it prompted by the bot comment in the PR or organic?

I'm asking because as you might know @iangmaia is working on improving the bot comments, https://wp.me/paaHJt-594 . Any feedback on how to make those visible and useful would be welcome 😄

[irfano]

Hi @irfano 👋 Thanks for the ping. Out of curiosity, was it prompted by #21912 (comment) or organic?

👋🏻 @mokagio! I'm not entirely sure what you're asking. I initially missed the bot's comment. I only read the first sentence of the comment and I thought it was a warning about the release notes change. Since I made a change on a release branch, I followed my usual procedure and notified the release manager (you).

Please, get in touch with a release manager if you want to update the final release notes.

I actually want this change to be included in the final release notes.

[mokagio]

@irfano

I initially missed the bot's comment. I only read the first sentence of the comment and I thought it was a warning about the release notes change.

Gotcha. That answers my question. What's one thing that can be improved in the bot comment to make it more visible / harder to miss?

Also confirming that this will be sent to editorialization as it was merged as part of the code freeze PR: #21911

[irfano]

Gotcha. That answers my question. What's one thing that can be improved in the bot comment to make it more visible / harder to miss?

The warning message looks fine. There's no need to improve it. I should have read it more carefully. The main reason I ignored the message is that Peril messages usually contain similar ignorable messages for me, such as:

[mokagio]

@irfano thanks for the info! 🙇‍♂️

Could you tell me more about why the warning in your screenshot is ignorable?

[irfano]

@irfano thanks for the info! 🙇‍♂️

Could you tell me more about why the warning in your screenshot is ignorable?

The warning suggests considering smaller PRs. But, in most cases, making 300+ lines changes is often the only practical approach. For instance, there is the same warning in the PR that I opened yesterday. It involves converting one class to Kotlin, and dividing it into smaller PRs wouldn't significantly improve the situation.

[mokagio]

in most cases, making 300+ lines changes is often the only practical approach

The example you gave is a great one for a case where one big change made sense, but I would challenge that "in most cases" 300+ lines is "the only practical approach."

In my experience so far, sequences of small PRs get reviewed and iterated upon much faster than one big PR. Have you experienced this?

Of course, there might be UI changes, ports, or mechanical refactors that change lots of code in one go which inevitably result in bigger diffs.

I'm pressing on this because if a warning is constantly ignored, either the warning is based on the wrong assumption and should be updated or removed, or we as a team need to stop ignoring it. Understanding where we fall in this case is very helpful for me.

[irfano]

In my experience so far, sequences of small PRs get reviewed and iterated upon much faster than one big PR. Have you experienced this?

Yes, certainly!

@mokagio, I think warning messages are beneficial. As I said previously, "I should have read it more carefully." The "300+ lines changes" message was ignorable in some of my PRs, but that shouldn't mean all warning messages will be ignorable.

[mokagio]

Thanks for the clarification @irfano 🙌