Merge pull request #553 from wordpress-mobile/release-5.0

Bump version to 5.0.0

.buildkite/pipeline.yml

@@ -15,6 +15,8 @@ steps:
     key: "test"
     command: |
       build_and_test_pod
+    artifact_paths:
+      - "fastlane/test_output/*.xcresult.zip"
     env: *common_env
     plugins: *common_plugins
 

CHANGELOG.md

@@ -34,7 +34,7 @@ _None._
 
 ### Breaking Changes
 
-- Remove CocoaLumberjack. Use `WPKitSetLoggingDelegate` to assign a logger to this library. [#550]
+_None._
 
 ### New Features
 
@@ -46,4 +46,14 @@ _None._
 
 ### Internal Changes
 
+_None._
+
+## [5.0.0](https://github.com/wordpress-mobile/WordPressKit-iOS/releases/tag/5.0.0)
+
+### Breaking Changes
+
+- Remove CocoaLumberjack. Use `WPKitSetLoggingDelegate` to assign a logger to this library. [#550]
+
+### Internal Changes
+
 - Add this changelog file. [#545]

WordPressKit.podspec

@@ -2,7 +2,7 @@
 
 Pod::Spec.new do |s|
   s.name          = 'WordPressKit'
-  s.version       = '4.58.2'
+  s.version       = '5.0.0'
 
   s.summary       = 'WordPressKit offers a clean and simple WordPress.com and WordPress.org API.'
   s.description   = <<-DESC
@@ -29,5 +29,5 @@ Pod::Spec.new do |s|
 
   # Use a loose restriction that allows both production and beta versions, up to the next major version.
   # If you want to update which of these is used, specify it in the host app.
-  s.dependency 'WordPressShared', '~> 2.0.0-beta'
+  s.dependency 'WordPressShared', '~> 2.0-beta'
 end

WordPressKit/WPKitLogging.m

@@ -23,7 +23,9 @@ void WPKitSetLoggingDelegate(id<WordPressLoggingDelegate> _Nullable logger)
             NSLog(@"[WordPressKit] Warning: %@ does not implement " #logFunc, logger); \
             return; \
         } \
-        [logger performSelector:@selector(logFunc) withObject:[[NSString alloc] initWithFormat:str arguments:args]]; \
+        /* Originally `performSelector:withObject:` was used to call the logging function, but for unknown reason */ \
+        /* it causes a crash on `objc_retain`. So I have to switch to this strange "syntax" to call the logging function directly. */ \
+        [logger logFunc [[NSString alloc] initWithFormat:str arguments:args]]; \
     })
 
 #define WPKitLog(logFunc) \

fastlane/Fastfile

@@ -8,8 +8,23 @@ platform :ios do
     run_tests(
       scheme: 'WordPressKit',
       prelaunch_simulator: true,
+      result_bundle: true,
       buildlog_path: File.join(__dir__, '.build', 'logs'),
       derived_data_path: File.join(__dir__, '.build', 'derived-data')
     )
+  rescue StandardError => e
+    $stdout.puts '^^^ +++'
+    $stdout.puts 'Test failed!'
+
+    result_bundle_path = 'fastlane/test_output/WordPressKit.xcresult'
+    if File.exist?(File.join(Bundler.root, result_bundle_path))
+      zip(
+        path: result_bundle_path,
+        output_path: "#{result_bundle_path}.zip",
+        verbose: false
+      )
+    end
+
+    raise e
   end
 end