Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_metadata_source doesn't add new entries #172

Open
loremattei opened this issue Nov 9, 2020 · 0 comments
Open

update_metadata_source doesn't add new entries #172

loremattei opened this issue Nov 9, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@loremattei
Copy link
Contributor

The android_update_metadata_source and ios_update_metadata_source can only update existing entries, but they don't add new entries to the file even if the entries are correctly defined in the parameters.

In order to add a new string, the user shall manually add it to the .po file. After that, release-toolkit is able to update them automatically.

We should fix the above actions so that they add new entries automatically when they are added to the parameters.

@loremattei loremattei added bug Something isn't working enhancement New feature or request labels Nov 9, 2020
@mokagio mokagio changed the title update_metadata_source doesn't add new entries update_metadata_source doesn't add new entries Jul 12, 2022
mokagio added a commit to wordpress-mobile/WordPress-iOS that referenced this issue Jul 21, 2022
We have to do this change manually because of the known issue which hasn't been addressed yet because of higher priority work in the pipeline.

See wordpress-mobile/release-toolkit#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant