Fail generate_strings_file_for_glotpress when it finds reused keys
#446
Comments
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this issue
Aug 21, 2023
This issue was revealed by a strings generation _warning_: [12:54:11]: ▸ Key "mySite.domain.focus.card.title" used with multiple values. Value "News" kept. Value "Reclaim your Google Domains" ignored. Unfortunately, we don't have the tooling at the moment to translate this warning into an error. See wordpress-mobile/release-toolkit#446
This was referenced Aug 21, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in wordpress-mobile/WordPress-iOS#19651,
genstringsdoes not throw an error upon reused keys, only a warning:That is not acceptable for us, because it leads to these easy to make errors going ignored and possibly making it past the code freeze stage.
I think we should be able to run the
genstringoutput through RegEx that can match strings with the formatKey "..." used with multiple values. Value "..." kept. Value "..." ignored., collect all the matches, and return them as errors.Note: I'm aware
"..."is not valid, or useful, for the RegEx, just using it to give an idea of the shape of the text to look for.See also wordpress-mobile/WordPress-iOS#20030.
The text was updated successfully, but these errors were encountered: