Add Hash-splat operator to GithubHelper methods #424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this solve?
As discussed here at PR #420. This PR aims to add the hash conversion operator (aka **) to the methods on GithubHelper that use the named param
options:
in their signature. With this, we hope to improve the legibility and make those methods calls cleaner.Good, but what is this Hash Operator?
This operator will allow the call site of those methods to just provide the
options:
variable/parameter directly as if they were keywords (kinda "flattening the Hash into keyword parameters") without having to wrap those options into{ … }
curly braces to make them a Hash. So the call site would look like this:Instead of
We'd have: