Add new organization domain fields #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
approved these changes
Nov 11, 2024
Comment on lines
+93
to
+97
| // Strategy used to verify the domain. | ||
| VerificationStrategy OrganizationDomainVerificationStrategy `json:"verification_strategy,omitempty"` | ||
|
|
||
| // Token used for DNS verification. | ||
| VerificationToken string `json:"verification_token,omitempty"` |
There was a problem hiding this comment.
Based on your thread, is the ultimate goal to have the domain data on the organization_domain events only, but for now they also reside on the organization events?
There was a problem hiding this comment.
oh no, I meant that the OrganizationID specifically is mostly useful in the context of organization domain events (since in organization events or the organization API you have the ID already from the parent organization object). it's included by the API in all cases though.
for the other fields, i don't expect VerificationStrategy or VerificationToken to be widely used, but i'm including them for completeness. State on the other hand is generally useful in all cases where this struct would be used
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds fields introduced with the domain verification product (
State,VerificationStrategy,VerificationToken), andOrganizationID, which is useful for parsing organization domain events.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.