reuse events #861
Merged
reuse events #861
+28
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsippl
requested review from
eaypek-tfh,
danielle-tfh and
carlomazzaferro
eaypek-tfh
force-pushed
the
ps/reuse-events
branch
from
5b1c039 to
4f8b1c6
Compare
eaypek-tfh
approved these changes
Dec 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating events for each chunk, we can just reuse them and use them for the whole db. This is supposed to also fix the mem leak that causes the service to crash on creating a new event after running for a long while.