Skip to content

Commit

Permalink
upgrade to open-telemetry/api 1.0.1
Browse files Browse the repository at this point in the history
  • Loading branch information
neiluJ committed Dec 19, 2023
1 parent 04b9667 commit f8d59db
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"monolog/monolog": "^2.0",
"nyholm/dsn": "^2.0",
"nyholm/psr7": "^1.5",
"open-telemetry/sdk": "^1.0@dev",
"open-telemetry/api": "^1.0@dev",
"open-telemetry/sdk": "^1.0.1",
"open-telemetry/api": "^1.0.1",
"open-telemetry/context": "^1.0@dev",
"open-telemetry/sem-conv": "^1.0@dev",
"promphp/prometheus_client_php": "^2.4",
Expand Down
10 changes: 5 additions & 5 deletions src/Metrics/Meter.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public function __construct(
) {
}

public function createCounter(string $name, string $unit = null, string $description = null): CounterInterface
public function createCounter(string $name, string $unit = null, string $description = null, array $advisory = []): CounterInterface

Check failure on line 26 in src/Metrics/Meter.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1)

Method Instrumentation\Metrics\Meter::createCounter() has parameter $advisory with no value type specified in iterable type array.
{
return new CounterAdapter($name, $description ?: '', $this->collectorRegistry);
}
Expand All @@ -33,22 +33,22 @@ public function createObservableCounter(string $name, string $unit = null, strin
throw new \LogicException(sprintf('Method %s is not implemented', __METHOD__));
}

public function createHistogram(string $name, string $unit = null, string $description = null): HistogramInterface
public function createHistogram(string $name, string $unit = null, string $description = null, array $advisory = []): HistogramInterface

Check failure on line 36 in src/Metrics/Meter.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1)

Method Instrumentation\Metrics\Meter::createHistogram() has parameter $advisory with no value type specified in iterable type array.
{
return new HistogramAdapter($name, $description ?: '', $this->collectorRegistry);
}

public function createObservableGauge(string $name, string $unit = null, string $description = null, callable ...$callbacks): ObservableGaugeInterface
public function createObservableGauge(string $name, string $unit = null, string $description = null, $advisory = [], callable ...$callbacks): ObservableGaugeInterface

Check failure on line 41 in src/Metrics/Meter.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1)

Method Instrumentation\Metrics\Meter::createObservableGauge() has parameter $advisory with no value type specified in iterable type array.
{
throw new \LogicException(sprintf('Method %s is not implemented', __METHOD__));
}

public function createUpDownCounter(string $name, string $unit = null, string $description = null): UpDownCounterInterface
public function createUpDownCounter(string $name, string $unit = null, string $description = null, array $advisory = []): UpDownCounterInterface

Check failure on line 46 in src/Metrics/Meter.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1)

Method Instrumentation\Metrics\Meter::createUpDownCounter() has parameter $advisory with no value type specified in iterable type array.
{
return new UpDownCounterAdapter($name, $description ?: '', $this->collectorRegistry);
}

public function createObservableUpDownCounter(string $name, string $unit = null, string $description = null, callable ...$callbacks): ObservableUpDownCounterInterface
public function createObservableUpDownCounter(string $name, string $unit = null, string $description = null, $advisory = [], callable ...$callbacks): ObservableUpDownCounterInterface

Check failure on line 51 in src/Metrics/Meter.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1)

Method Instrumentation\Metrics\Meter::createObservableUpDownCounter() has parameter $advisory with no value type specified in iterable type array.
{
throw new \LogicException(sprintf('Method %s is not implemented', __METHOD__));
}
Expand Down

0 comments on commit f8d59db

Please sign in to comment.