Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Audit reports #4143

Merged
merged 2 commits into from
Oct 25, 2024
Merged

docs: Audit reports #4143

merged 2 commits into from
Oct 25, 2024

Conversation

djb15
Copy link
Collaborator

@djb15 djb15 commented Oct 23, 2024

No description provided.

@djb15 djb15 requested a review from evan-gray as a code owner October 23, 2024 18:15
@evan-gray evan-gray requested review from SEJeff, johnsaigle, pleasew8t and mdulin2 and removed request for evan-gray October 24, 2024 14:50
johnsaigle
johnsaigle previously approved these changes Oct 24, 2024
View reviewed changes
pleasew8t
pleasew8t reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@pleasew8t pleasew8t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that gets me is the naming convention. I think we should consider something like <date>_<audit-firm>_<project-name>.pdf.

@pleasew8t pleasew8t merged commit 879b666 into main Oct 25, 2024
24 checks passed
@pleasew8t pleasew8t deleted the audit-reports branch October 25, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleasew8t pleasew8t pleasew8t approved these changes

@johnsaigle johnsaigle johnsaigle approved these changes

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djb15 @johnsaigle @pleasew8t