Skip to content

Commit

Permalink
Merge pull request #1162 from TheBackstabi/master
Browse files Browse the repository at this point in the history
[Rogue] Implement MH weapon optimization for Human/Orc Combat Rogues.
  • Loading branch information
1337LutZ authored Nov 4, 2024
2 parents 8758bb2 + a804a56 commit 501e8d3
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion ui/rogue/combat/sim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { IndividualSimUI, registerSpecConfig } from '../../core/individual_sim_u
import { Player } from '../../core/player';
import { PlayerClasses } from '../../core/player_classes';
import { APLRotation } from '../../core/proto/apl';
import { Debuffs, Faction, IndividualBuffs, ItemSlot, PartyBuffs, PseudoStat, Race, RaidBuffs, Spec, Stat } from '../../core/proto/common';
import { Debuffs, Faction, IndividualBuffs, ItemSlot, PartyBuffs, PseudoStat, Race, RaidBuffs, Spec, Stat, WeaponType } from '../../core/proto/common';
import { RogueOptions_PoisonImbue } from '../../core/proto/rogue';
import { StatCapType } from '../../core/proto/ui';
import { StatCap, Stats, UnitStat } from '../../core/proto_utils/stats';
Expand Down Expand Up @@ -206,6 +206,16 @@ export class CombatRogueSimUI extends IndividualSimUI<Spec.SpecCombatRogue> {

return softCaps;
},
updateGearStatsModifier(baseStats: Stats) {
// Human/Orc racials for MH. Maxing Expertise for OH is a DPS loss when the MH matches the racial.
const mhWepType = player.getEquippedItem(ItemSlot.ItemSlotMainHand)?.item.weaponType;
if ((player.getRace() == Race.RaceHuman && (mhWepType == WeaponType.WeaponTypeSword || mhWepType == WeaponType.WeaponTypeMace) ||
(player.getRace() == Race.RaceOrc && mhWepType == WeaponType.WeaponTypeAxe)))
{
return baseStats.addStat(Stat.StatExpertiseRating, 90);
}
return baseStats
},
});
});

Expand Down

0 comments on commit 501e8d3

Please sign in to comment.