Merge pull request #599 from wowsims/fixhunter

Fix crit metrics
wowsims · Jun 2, 2024 · 99fc5de · 99fc5de
2 parents bb7a991 + 284dde6
commit 99fc5de
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/sim/core/spell_outcome.go b/sim/core/spell_outcome.go
@@ -34,8 +34,10 @@ func (dot *Dot) OutcomeTickPhysicalCrit(sim *Simulation, result *SpellResult, at
 	if dot.Spell.PhysicalCritCheck(sim, attackTable) {
 		result.Outcome = OutcomeCrit
 		result.Damage *= dot.Spell.CritMultiplier
+		dot.Spell.SpellMetrics[result.Target.UnitIndex].Crits++
 	} else {
 		result.Outcome = OutcomeHit
+		dot.Spell.SpellMetrics[result.Target.UnitIndex].Hits++
 	}
 }
 

diff --git a/sim/hunter/multi_shot.go b/sim/hunter/multi_shot.go
@@ -52,14 +52,15 @@ func (hunter *Hunter) registerMultiShotSpell() {
 					spell.DealDamage(sim, baseDamageArray[hitIndex])
 					if hunter.Talents.SerpentSpread > 0 {
 						ss := hunter.SerpentSting.Dot(curTarget)
+
+						hunter.SerpentSting.SpellMetrics[target.UnitIndex].Hits--
 						ss.NumberOfTicks = (3 + (hunter.Talents.SerpentSpread * 3)) / 2
 						ss.Apply(sim)
 						hunter.ImprovedSerpentSting.Cast(sim, curTarget)
 					}
 					curTarget = sim.Environment.NextTargetUnit(curTarget)
 				}
 			})
-
 		},
 	})
 }
diff --git a/sim/hunter/serpent_sting.go b/sim/hunter/serpent_sting.go
@@ -93,7 +93,6 @@ func (hunter *Hunter) registerSerpentStingSpell() {
 						hunter.ImprovedSerpentSting.Cast(sim, target)
 					}
 				}
-
 				spell.DealOutcome(sim, result)
 			})
 		},

diff --git a/ui/hunter/survival/sim.ts b/ui/hunter/survival/sim.ts
@@ -68,7 +68,6 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecSurvivalHunter, {
 		if (player.getTalents().pathing) {
 			stats = stats.addStat(Stat.StatMeleeHaste, player.getTalents().pathing * Mechanics.HASTE_RATING_PER_HASTE_PERCENT);
 		}
-
 		return {
 			talents: stats,
 		};