Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate APL Validation Warnings for each APL Value #1209

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

raethkcj
Copy link
Contributor

@raethkcj raethkcj commented Nov 15, 2024

Adds the ability to attach validation warnings to individual APL Values that trigger them, rather than attaching them all to the parent Action.

Does this by assigning a UUID to each APLValue that matches its input's CSS ID, which gets sent to the backend, validated, and returned to the frontend with warnings if they exist.

Seemed like less traffic then putting the warnings themselves in APLValues and returning the whole APLRotation 🤷

TODO

  • Audit existing APLValue ValidationWarnings and decide whether each should move to this system
  • Pass the parent AuraSet value to APLValueTrinketStatProcCheck so it can warn appropriately
  • Consider renaming Warnings to Messages, and adding a log-level-ish enum to them to label as Warning, Info, etc. and display them with a different icon+message on the frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant