seems like stacks should decrease on most procs (tentative)

wowsims · Oct 11, 2023 · 0e9b422 · 0e9b422
1 parent 0419459
commit 0e9b422
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/sim/common/wotlk/other_effects.go b/sim/common/wotlk/other_effects.go
@@ -360,7 +360,7 @@ func init() {
 
 		core.ApplyProcTriggerCallback(&character.Unit, activeAura, core.ProcTrigger{
 			Callback: core.CallbackOnSpellHitDealt,
-			ProcMask: core.ProcMaskSpellOrProc,
+			ProcMask: core.ProcMaskSpellOrProc | core.ProcMaskWeaponProc | core.ProcMaskSuppressedProc,
 			Outcome:  core.OutcomeCrit,
 			Handler: func(sim *core.Simulation, _ *core.Spell, _ *core.SpellResult) {
 				activeAura.RemoveStack(sim)

diff --git a/sim/priest/shadow/TestShadow.results b/sim/priest/shadow/TestShadow.results
@@ -476,8 +476,8 @@ dps_results: {
 dps_results: {
  key: "TestShadow-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 7248.60632
-  tps: 6986.5685
+  dps: 7231.56154
+  tps: 6969.54916
  }
 }
 dps_results: {

diff --git a/sim/rogue/TestAssassination.results b/sim/rogue/TestAssassination.results
@@ -463,8 +463,8 @@ dps_results: {
 dps_results: {
  key: "TestAssassination-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 6727.7319
-  tps: 4776.68965
+  dps: 6583.88452
+  tps: 4674.55801
  }
 }
 dps_results: {

diff --git a/sim/rogue/TestCombat.results b/sim/rogue/TestCombat.results
@@ -491,8 +491,8 @@ dps_results: {
 dps_results: {
  key: "TestCombat-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 6130.09429
-  tps: 4352.36695
+  dps: 6014.37701
+  tps: 4270.20768
  }
 }
 dps_results: {

diff --git a/sim/rogue/TestSubtlety.results b/sim/rogue/TestSubtlety.results
@@ -463,8 +463,8 @@ dps_results: {
 dps_results: {
  key: "TestSubtlety-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 8017.0266
-  tps: 5691.33135
+  dps: 7930.30075
+  tps: 5626.91318
  }
 }
 dps_results: {

diff --git a/sim/shaman/enhancement/TestEnhancement.results b/sim/shaman/enhancement/TestEnhancement.results
@@ -547,8 +547,8 @@ dps_results: {
 dps_results: {
  key: "TestEnhancement-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 7503.64293
-  tps: 4138.56917
+  dps: 7454.42569
+  tps: 4109.93071
  }
 }
 dps_results: {