fix shadowy inishgt and imp. spirit tap (#4049)

wowsims · Nov 17, 2023 · 57593f3 · 57593f3
1 parent 4fb6b24
commit 57593f3
Show file tree

Hide file tree

Showing 3 changed files with 345 additions and 340 deletions.
diff --git a/sim/priest/priest.go b/sim/priest/priest.go
@@ -116,14 +116,18 @@ func (priest *Priest) AddPartyBuffs(_ *proto.PartyBuffs) {
 }
 
 func (priest *Priest) Initialize() {
-	// Shadow Insight gained from Glyph of Shadow
-	// Finalized spirit off gear and not dynamic spirit (e.g. Spirit Tap does not increase this)
-	priest.ShadowyInsightAura = priest.NewTemporaryStatsAura(
-		"Shadowy Insight",
-		core.ActionID{SpellID: 61792},
-		stats.Stats{stats.SpellPower: priest.GetStat(stats.Spirit) * 0.30},
-		time.Second*10,
-	)
+	statDep := priest.NewDynamicStatDependency(stats.Spirit, stats.SpellPower, 0.3)
+	priest.ShadowyInsightAura = priest.GetOrRegisterAura(core.Aura{
+		Label:    "Shadowy Insight",
+		Duration: time.Second * 10,
+		ActionID: core.ActionID{SpellID: 61792},
+		OnGain: func(aura *core.Aura, sim *core.Simulation) {
+			priest.EnableDynamicStatDep(sim, statDep)
+		},
+		OnExpire: func(aura *core.Aura, sim *core.Simulation) {
+			priest.DisableDynamicStatDep(sim, statDep)
+		},
+	})
 
 	priest.registerSetBonuses()
 	priest.registerDevouringPlagueSpell()