talisman is on cast complete. mind flay should proce it twice

wowsims · Jul 17, 2023 · 632b052 · 632b052
1 parent 5b1a28d
commit 632b052
Show file tree

Hide file tree

Showing 4 changed files with 330 additions and 336 deletions.
diff --git a/sim/common/wotlk/stat_bonus_stacking.go b/sim/common/wotlk/stat_bonus_stacking.go
@@ -328,8 +328,6 @@ func init() {
 		CD:        time.Minute * 2,
 		Callback:  core.CallbackOnCastComplete,
 		ProcMask:  core.ProcMaskSpellOrProc,
-		Outcome:   core.OutcomeLanded,
-		Harmful:   true,
 	})
 	newStackingStatBonusCD(StackingStatBonusCD{
 		Name:        "Ferver of the Frostborn",
@@ -359,10 +357,8 @@ func init() {
 		MaxStacks: 8,
 		Bonus:     stats.Stats{stats.MeleeHaste: 57, stats.SpellHaste: 57},
 		CD:        time.Minute * 2,
-		Callback:  core.CallbackOnSpellHitDealt,
+		Callback:  core.CallbackOnCastComplete,
 		ProcMask:  core.ProcMaskSpellOrProc,
-		Outcome:   core.OutcomeLanded,
-		Harmful:   true,
 	})
 	newStackingStatBonusCD(StackingStatBonusCD{
 		Name:       "Binding Stone",
@@ -403,10 +399,8 @@ func init() {
 		MaxStacks: 8,
 		Bonus:     stats.Stats{stats.MeleeHaste: 64, stats.SpellHaste: 64},
 		CD:        time.Minute * 2,
-		Callback:  core.CallbackOnSpellHitDealt,
+		Callback:  core.CallbackOnCastComplete,
 		ProcMask:  core.ProcMaskSpellOrProc,
-		Outcome:   core.OutcomeLanded,
-		Harmful:   true,
 	})
 	newStackingStatBonusCD(StackingStatBonusCD{
 		Name:       "Binding Light H",
@@ -447,10 +441,8 @@ func init() {
 		MaxStacks: 8,
 		Bonus:     stats.Stats{stats.MeleeHaste: 64, stats.SpellHaste: 64},
 		CD:        time.Minute * 2,
-		Callback:  core.CallbackOnSpellHitDealt,
+		Callback:  core.CallbackOnCastComplete,
 		ProcMask:  core.ProcMaskSpellOrProc,
-		Outcome:   core.OutcomeLanded,
-		Harmful:   true,
 	})
 	newStackingStatBonusCD(StackingStatBonusCD{
 		Name:       "Binding Stone H",

diff --git a/sim/priest/mind_blast.go b/sim/priest/mind_blast.go
@@ -21,8 +21,10 @@ func (priest *Priest) registerMindBlastSpell() {
 		ActionID:    core.ActionID{SpellID: 48301},
 		ProcMask:    core.ProcMaskProc,
 		SpellSchool: core.SpellSchoolShadow,
+		Flags:       core.SpellFlagNoMetrics,
 		ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
 			MindTraumaAura(target).Activate(sim)
+			spell.CalcAndDealOutcome(sim, target, spell.OutcomeAlwaysHit)
 		},
 	})
 

diff --git a/sim/priest/mind_flay.go b/sim/priest/mind_flay.go
@@ -109,7 +109,7 @@ func (priest *Priest) newMindFlaySpell(numTicks int32) *core.Spell {
 					if rolloverChance == 1 || sim.RandomFloat("Pain and Suffering") < rolloverChance {
 						priest.ShadowWordPain.Dot(target).Rollover(sim)
 						// trinkets can proc from the re-application
-						priest.Unit.OnCastComplete(sim, priest.ShadowWordPain)
+						priest.OnCastComplete(sim, priest.ShadowWordPain)
 					}
 				}
 				spell.Dot(target).Apply(sim)