[core] handle WeaponAttacks via a "task"-like system

[core] slightly speedup advance() by using an inlineable tryAdvance() stub
wowsims · Oct 31, 2023 · 73e8c8e · 73e8c8e
1 parent c089322
commit 73e8c8e
Show file tree

Hide file tree

Showing 48 changed files with 7,120 additions and 7,142 deletions.
diff --git a/sim/common/tbc/melee_trinkets.go b/sim/common/tbc/melee_trinkets.go
@@ -25,7 +25,7 @@ func init() {
 
 	core.NewItemEffect(11815, func(agent core.Agent) {
 		character := agent.GetCharacter()
-		if !character.AutoAttacks.AutoSwingMelee() {
+		if !character.AutoAttacks.AutoSwingMelee {
 			return
 		}
 
@@ -40,7 +40,7 @@ func init() {
 			Label:    "Hand of Justice",
 			Duration: core.NeverExpires,
 			OnInit: func(aura *core.Aura, sim *core.Simulation) {
-				config := character.AutoAttacks.MHConfig
+				config := *character.AutoAttacks.MHConfig()
 				config.ActionID = core.ActionID{ItemID: 11815}
 				handOfJusticeSpell = character.GetOrRegisterSpell(config)
 			},

diff --git a/sim/common/wotlk/capacitors.go b/sim/common/wotlk/capacitors.go
@@ -172,7 +172,7 @@ func init() {
 
 		core.NewItemEffect(itemID, func(agent core.Agent) {
 			character := agent.GetCharacter()
-			if !character.AutoAttacks.AutoSwingMelee() {
+			if !character.AutoAttacks.AutoSwingMelee {
 				return
 			}
 
@@ -184,24 +184,24 @@ func init() {
 					SpellSchool:      core.SpellSchoolPhysical,
 					ProcMask:         core.ProcMaskMeleeMHSpecial,
 					Flags:            core.SpellFlagMeleeMetrics | core.SpellFlagIncludeTargetBonusDamage | core.SpellFlagNoOnCastComplete,
-					DamageMultiplier: character.AutoAttacks.MHConfig.DamageMultiplier * 0.5,
-					CritMultiplier:   character.AutoAttacks.MHConfig.CritMultiplier,
-					ThreatMultiplier: character.AutoAttacks.MHConfig.ThreatMultiplier,
+					DamageMultiplier: character.AutoAttacks.MHConfig().DamageMultiplier * 0.5,
+					CritMultiplier:   character.AutoAttacks.MHConfig().CritMultiplier,
+					ThreatMultiplier: character.AutoAttacks.MHConfig().ThreatMultiplier,
 					ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
 						baseDamage := character.MHWeaponDamage(sim, spell.MeleeAttackPower())
 						spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMeleeWeaponSpecialHitAndCrit)
 					},
 				})
 
-				if character.AutoAttacks.IsDualWielding() {
+				if character.AutoAttacks.IsDualWielding {
 					ohSpell = character.GetOrRegisterSpell(core.SpellConfig{
 						ActionID:         core.ActionID{SpellID: 71434}, // "Manifest Anger"
 						SpellSchool:      core.SpellSchoolPhysical,
 						ProcMask:         core.ProcMaskMeleeOHSpecial,
 						Flags:            core.SpellFlagMeleeMetrics | core.SpellFlagIncludeTargetBonusDamage | core.SpellFlagNoOnCastComplete,
-						DamageMultiplier: character.AutoAttacks.OHConfig.DamageMultiplier * 0.5,
-						CritMultiplier:   character.AutoAttacks.OHConfig.CritMultiplier,
-						ThreatMultiplier: character.AutoAttacks.OHConfig.ThreatMultiplier,
+						DamageMultiplier: character.AutoAttacks.OHConfig().DamageMultiplier * 0.5,
+						CritMultiplier:   character.AutoAttacks.OHConfig().CritMultiplier,
+						ThreatMultiplier: character.AutoAttacks.OHConfig().ThreatMultiplier,
 						ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
 							baseDamage := character.OHWeaponDamage(sim, spell.MeleeAttackPower())
 							spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMeleeWeaponSpecialHitAndCrit)