From 82e6a61a6f11bb5cef9ebd25b98569e87666cb51 Mon Sep 17 00:00:00 2001 From: Josh Date: Thu, 26 Oct 2023 17:23:48 -0400 Subject: [PATCH] fix parry crit cap logic (#3956) --- ui/core/player.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui/core/player.ts b/ui/core/player.ts index 2dda11dda0..dfb021353c 100644 --- a/ui/core/player.ts +++ b/ui/core/player.ts @@ -687,10 +687,14 @@ export class Player { const hasOffhandWeapon = this.getGear().getEquippedItem(ItemSlot.ItemSlotOffHand)?.item.weaponSpeed !== undefined; // Due to warrior HS bug, hit cap for crit cap calculation should be 8% instead of 27% const meleeHitCap = hasOffhandWeapon && this.spec != Spec.SpecWarrior ? 27.0 : 8.0; - const expertiseCap = this.getInFrontOfTarget() ? 20.5 : 6.5; + const dodgeCap = 6.5 + const parryCap = this.getInFrontOfTarget() ? 14.0 : 0 + const expertiseCap = dodgeCap + parryCap const remainingMeleeHitCap = Math.max(meleeHitCap - meleeHit, 0.0); - const remainingExpertiseCap = Math.max(expertiseCap - expertise, 0.0) + const remainingDodgeCap = Math.max(dodgeCap - expertise, 0.0) + const remainingParryCap = Math.max(parryCap - expertise, 0.0) + const remainingExpertiseCap = remainingDodgeCap + remainingParryCap let specSpecificOffset = 0.0;