Merge pull request #3849 from wowsims/apl

Fix prepull warnings attribution bug
wowsims · Oct 8, 2023 · 8a1ccb1 · 8a1ccb1
2 parents fec4d75 + 200b8c7
commit 8a1ccb1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/sim/core/apl.go b/sim/core/apl.go
@@ -65,7 +65,8 @@ func (unit *Unit) newAPLRotation(config *proto.APLRotation) *APLRotation {
 	}
 
 	// Parse prepull actions
-	for prepullIdx, prepullItem := range config.PrepullActions {
+	for i, prepullItem := range config.PrepullActions {
+		prepullIdx := i // Save to local variable for correct lambda capture behavior
 		rotation.doAndRecordWarnings(&rotation.prepullWarnings[prepullIdx], true, func() {
 			if !prepullItem.Hide {
 				doAtVal := rotation.newAPLValue(prepullItem.DoAtValue)