fix MCD logic for balance, since it modifies the pointer (#3788)

wowsims · Sep 30, 2023 · 9ae34b3 · 9ae34b3
1 parent bf2a303
commit 9ae34b3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/sim/core/major_cooldown.go b/sim/core/major_cooldown.go
@@ -421,9 +421,9 @@ func (mcdm *majorCooldownManager) GetMajorCooldown(actionID ActionID) *MajorCool
 	return nil
 }
 func (mcdm *majorCooldownManager) GetMajorCooldownIgnoreTag(actionID ActionID) *MajorCooldown {
-	for _, mcd := range mcdm.initialMajorCooldowns {
+	for _, mcd := range mcdm.majorCooldowns {
 		if mcd.Spell.SameActionIgnoreTag(actionID) {
-			return &mcd
+			return mcd
 		}
 	}
 	return nil

diff --git a/sim/mage/mage.go b/sim/mage/mage.go
@@ -141,13 +141,13 @@ func (mage *Mage) Initialize() {
 	mage.registerBlastWaveSpell()
 	mage.registerDragonsBreathSpell()
 
-	if mirrorImageMCD := mage.GetMajorCooldownIgnoreTag(mage.MirrorImage.ActionID); !mage.IsUsingAPL && mirrorImageMCD != nil {
-		if len(mirrorImageMCD.GetTimings()) == 0 {
-			mage.RegisterPrepullAction(-2000*time.Millisecond, func(sim *core.Simulation) {
+	mage.RegisterPrepullAction(-2000*time.Millisecond, func(sim *core.Simulation) {
+		if mirrorImageMCD := mage.GetMajorCooldownIgnoreTag(mage.MirrorImage.ActionID); !mage.IsUsingAPL && mirrorImageMCD != nil {
+			if len(mirrorImageMCD.GetTimings()) == 0 {
 				mage.MirrorImage.Cast(sim, nil)
-			})
+			}
 		}
-	}
+	})
 }
 
 func (mage *Mage) Reset(sim *core.Simulation) {