Finish rogue

wowsims · Jan 5, 2024 · c097de6 · c097de6
1 parent 37e1b78
commit c097de6
Show file tree

Hide file tree

Showing 10 changed files with 877 additions and 892 deletions.
diff --git a/sim/core/debuffs.go b/sim/core/debuffs.go
@@ -191,24 +191,9 @@ func applyDebuffEffects(target *Unit, targetIdx int, debuffs *proto.Debuffs, rai
 }
 
 func ScheduledMajorArmorAura(aura *Aura, options PeriodicActionOptions, raid *proto.Raid) {
-	// Individual rogue sim rotation option messes with these debuff options,
-	// so it has to be handled separately.
-	allRogues := RaidPlayersWithClass(raid, proto.Class_ClassRogue)
-	singleExposeDelay := len(allRogues) == 1 &&
-		allRogues[0].Spec.(*proto.Player_Rogue).Rogue.Rotation.ExposeArmorFrequency == proto.Rogue_Rotation_Once
-
-	if singleExposeDelay {
-		target := aura.Unit
-		exposeArmorAura := ExposeArmorAura(target, false)
-		exposeArmorAura.ApplyOnExpire(func(_ *Aura, sim *Simulation) {
-			aura.Duration = NeverExpires
-			StartPeriodicAction(sim, options)
-		})
-	} else {
-		aura.OnReset = func(aura *Aura, sim *Simulation) {
-			aura.Duration = NeverExpires
-			StartPeriodicAction(sim, options)
-		}
+	aura.OnReset = func(aura *Aura, sim *Simulation) {
+		aura.Duration = NeverExpires
+		StartPeriodicAction(sim, options)
 	}
 }
 

diff --git a/sim/mage/TestArcane.results b/sim/mage/TestArcane.results
@@ -252,8 +252,8 @@ dps_results: {
 dps_results: {
  key: "TestArcane-AllItems-EphemeralSnowflake-50260"
  value: {
-  dps: 10727.16841
-  tps: 6570.11619
+  dps: 10738.79708
+  tps: 6577.6561
  }
 }
 dps_results: {

diff --git a/sim/mage/TestFire.results b/sim/mage/TestFire.results
@@ -770,8 +770,8 @@ dps_results: {
 dps_results: {
  key: "TestFire-Settings-Troll-p3_fire_alliance-Fire-fire-FullBuffs-LongMultiTarget"
  value: {
-  dps: 38064.82304
-  tps: 32963.64697
+  dps: 38085.36222
+  tps: 32980.78258
  }
 }
 dps_results: {
@@ -791,8 +791,8 @@ dps_results: {
 dps_results: {
  key: "TestFire-Settings-Troll-p3_fire_alliance-Fire-fire-NoBuffs-LongMultiTarget"
  value: {
-  dps: 22173.53497
-  tps: 20541.48297
+  dps: 22222.81509
+  tps: 20575.92958
  }
 }
 dps_results: {